Increase scaling factor for reserved RAM to 5%#1826
Merged
henrymercer merged 1 commit intomainfrom Aug 7, 2023
Merged
Conversation
adityasharad
approved these changes
Aug 7, 2023
| const scaledAmount = 0.025 * Math.max(totalMemoryMegaBytes - 8 * 1024, 0); | ||
| // Reserve an additional 5% of the amount of memory above 8 GB, since the amount used by the | ||
| // kernel for page tables scales with the size of physical memory. | ||
| const scaledAmount = 0.05 * Math.max(totalMemoryMegaBytes - 8 * 1024, 0); |
Contributor
There was a problem hiding this comment.
Future: pull this out into its own constant so you just need to modify that.
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Experimentally we are seeing that the 2.5% scaling factor is still causing OOMs on larger runners. This PR bumps this factor to 5%.
Merge / deployment checklist