Conversation
henrymercer
reviewed
Jan 17, 2024
Contributor
henrymercer
left a comment
henrymercer
left a comment
There was a problem hiding this comment.
This PR would disable Lombok for CLI v2.14.0 to 2.14.3, where it is enabled by the feature flag currently but it is not enabled by default in the CLI. Should we change this to set CODEQL_EXTRACTOR_JAVA_RUN_ANNOTATION_PROCESSORS to true for CLIs >= v2.14.0?
igfoo
force-pushed
the
igfoo/remove_lombok_ff
branch
from
725a8f0 to
0b31444
Compare
Member
Author
|
Good point, thanks! I've made it check for 2.14.0-2.14.3, so we know when it's safe to remove it in the future. I've amended the commits, so that the history is simpler (rather than removing code in one commit, then partially reinstating it in a later one). |
henrymercer
previously approved these changes
Jan 19, 2024
We still set the env var for 2.14.0 - 2.14.3, as they defaulted to not enabling Lombok support but had support enabled by the feature flag.
igfoo
force-pushed
the
igfoo/remove_lombok_ff
branch
from
0b31444 to
545bf65
Compare
henrymercer
approved these changes
Jan 19, 2024
This was referenced Jan 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This essentially reverts #1809
Merge / deployment checklist