Internal queries: Replace deprecated predicates#2098
Merged
henrymercer merged 1 commit intomainfrom Jan 24, 2024
Merged
Conversation
angelapwen
approved these changes
Jan 24, 2024
Contributor
angelapwen
left a comment
angelapwen
left a comment
There was a problem hiding this comment.
Thanks! Out of curiosity, how did you find these were about to be deprecated? I'm not seeing it in the upcoming CLI release changelog
Contributor
Author
|
We've been getting deprecation warnings for some time in the logs, e.g. https://github.com/github/codeql-action/actions/runs/7627510974/job/20776479874. These are also visible if you open the queries in VS Code. This links into our discussion about improving changelogs — since it's a JS language support change these changes are surfaced at https://github.com/github/codeql/blob/codeql-cli-2.16.1/javascript/ql/lib/CHANGELOG.md#087. |
This was referenced Jan 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These predicates will be removed as of the next CLI release. Also remove
getEntrypoint()inqueries/required-action-input.qlsince it is unused.Merge / deployment checklist