-
Notifications
You must be signed in to change notification settings - Fork 439
Support ignoring generated files #3318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 1 commit
1512f40
3eaf000
846f859
b4db382
1782089
02b2c55
644e2b9
055e6b6
c7d0b92
5f5c095
9c3f69d
546ea07
7beb642
4bd7556
417a8c2
d5b3d42
6a02be4
9e2fa74
cb2dd2e
dc2428c
bc75091
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
isDynamic check from isCCR
The analysis key already tells us this under normal conditions
- Loading branch information
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -258,15 +258,12 @@ export function isDefaultSetup(): boolean { | |
| return isDynamicWorkflow() && !isCCR(); | ||
| } | ||
|
|
||
| /* The analysis key prefix used for CCR. */ | ||
| const CCR_KEY_PREFIX = "dynamic/copilot-pull-request-reviewer"; | ||
|
|
||
| /** Determines whether we are running in CCR. */ | ||
| export function isCCR(): boolean { | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What about introducing an environment variable we set in CCR, rather than relying on the analysis key?
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. As discussed elsewhere, that is sort of what we are doing here already (and we decide on whether are in CCR in other places in the same way currently). A better solution would be to add a new analysis kind (or similar) for CCR, but that would be more work and currently the same as I'd suggest we should stick with this for the moment (since we also use the same approach elsewhere) and look at improving it longer-term. |
||
| return ( | ||
| (isDynamicWorkflow() && | ||
| process.env[EnvVar.ANALYSIS_KEY]?.startsWith( | ||
| "dynamic/copilot-pull-request-reviewer", | ||
| )) || | ||
| false | ||
| ); | ||
| return process.env[EnvVar.ANALYSIS_KEY]?.startsWith(CCR_KEY_PREFIX) || false; | ||
| } | ||
|
|
||
| export function prettyPrintInvocation(cmd: string, args: string[]): string { | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.