Unified: fix test output#21901
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates Unified Swift test “golden” outputs to match the post-#21841 AST structure (notably the new statement: wrapping and reshaped fields), ensuring the existing extractor/corpus tests compare against current dumps.
Changes:
- Refreshes
unified/ql/test/library-tests/BasicTest/test.expectedto reflect the new node output shape. - Regenerates Swift corpus expected dumps under
unified/extractor/tests/corpus/swift/to match the updated mapped AST format (e.g.,statement:blocks, renamed/re-nested fields likefunction:/suffix:andexpr:).
Show a summary per file
| File | Description |
|---|---|
| unified/ql/test/library-tests/BasicTest/test.expected | Updates expected BasicTest output to match new node emission/structure. |
| unified/extractor/tests/corpus/swift/variables.txt | Refreshes Swift variable-related corpus expected AST dumps to new schema/shape. |
| unified/extractor/tests/corpus/swift/types.txt | Refreshes Swift type declaration corpus expected AST dumps to new schema/shape. |
| unified/extractor/tests/corpus/swift/optionals-and-errors.txt | Refreshes optional/error-handling corpus expected AST dumps to new schema/shape. |
| unified/extractor/tests/corpus/swift/operators.txt | Refreshes operator expression corpus expected AST dumps to new schema/shape. |
| unified/extractor/tests/corpus/swift/loops.txt | Refreshes loop corpus expected AST dumps to new schema/shape. |
| unified/extractor/tests/corpus/swift/literals.txt | Refreshes literal corpus expected AST dumps to new schema/shape. |
| unified/extractor/tests/corpus/swift/functions.txt | Refreshes function-related corpus expected AST dumps to new schema/shape. |
| unified/extractor/tests/corpus/swift/desugar.txt | Refreshes desugaring corpus expected AST dumps to new schema/shape. |
| unified/extractor/tests/corpus/swift/control-flow.txt | Refreshes control-flow corpus expected AST dumps to new schema/shape. |
| unified/extractor/tests/corpus/swift/collections.txt | Refreshes collections/subscript corpus expected AST dumps to new schema/shape. |
| unified/extractor/tests/corpus/swift/closures.txt | Refreshes closure corpus expected AST dumps to new schema/shape. |
Copilot's findings
- Files reviewed: 12/12 changed files
- Comments generated: 0
tausbn
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updating test output after #21841 was merged. These are not yet run on CI