Skip to content

Disabled option behavior fix#5

Merged
muan merged 3 commits into
masterfrom
fix-disable-click
Jan 14, 2019
Merged

Disabled option behavior fix#5
muan merged 3 commits into
masterfrom
fix-disable-click

Conversation

@muan
Copy link
Copy Markdown
Contributor

@muan muan commented Jan 11, 2019

github/auto-complete-element#15 needs this 👀 . On a disabled option:

  • commit event should not fire on click
  • preventDefault should be called on enter/tab

cc @github/web-systems

muan added 3 commits January 11, 2019 16:25
preventDefault if selection exist but is disabled like how button[disabled] would behave
@muan muan merged commit 2965e68 into master Jan 14, 2019
@muan muan deleted the fix-disable-click branch January 14, 2019 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants