Skip to content

Fix npm publish workflow for OIDC publishing#10

Merged
devm33 merged 4 commits into
mainfrom
devm33/fix-npm
Apr 8, 2026
Merged

Fix npm publish workflow for OIDC publishing#10
devm33 merged 4 commits into
mainfrom
devm33/fix-npm

Conversation

@devm33

@devm33 devm33 commented Apr 8, 2026

Copy link
Copy Markdown
Member

Summary

Fixes the npm publish workflow to work correctly with OIDC-based publishing.

Successful run: https://github.com/github/copilot-engine-sdk/actions/runs/24145290995

Published package: https://www.npmjs.com/package/@github/copilot-engine-sdk

Changes

  • Upgrade Node.js to 24 in the publish workflow to get an npm version recent enough to support OIDC token-based publishing to the npm registry
  • Remove tee piping from npm publish command to avoid silent failures where tee masks non-zero exit codes
  • Replace tee -a with >> for gh release create to preserve exit code propagation while still appending to the step summary
  • Fix package.json repository URLnpm pkg fix corrected the URL to use the git+https:// prefix per npm conventions

Copilot AI review requested due to automatic review settings April 8, 2026 16:04
@devm33 devm33 requested a review from a team as a code owner April 8, 2026 16:04

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the project’s npm publishing GitHub Actions workflow to better support OIDC-based publishing and improve failure/exit-code handling, plus aligns the package metadata with npm repository URL conventions.

Changes:

  • Bump the publish workflow’s Node.js version to 24 (to pick up a newer npm with OIDC support).
  • Remove tee piping from npm publish to avoid masking non-zero exit codes.
  • Replace tee -a with file append redirection for gh release create output, and fix package.json repository URL format.
Show a summary per file
File Description
package.json Adjusts the repository.url to git+https://... per npm conventions.
.github/workflows/publish.yml Updates Node version and refactors publish/release commands to preserve exit codes (and adjust summary logging).

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 2/2 changed files
  • Comments generated: 1

Comment thread .github/workflows/publish.yml Outdated
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@devm33 devm33 merged commit 1ce1e29 into main Apr 8, 2026
6 checks passed
@devm33 devm33 deleted the devm33/fix-npm branch April 8, 2026 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants