Fix npm publish workflow for OIDC publishing#10
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the project’s npm publishing GitHub Actions workflow to better support OIDC-based publishing and improve failure/exit-code handling, plus aligns the package metadata with npm repository URL conventions.
Changes:
- Bump the publish workflow’s Node.js version to 24 (to pick up a newer npm with OIDC support).
- Remove
teepiping fromnpm publishto avoid masking non-zero exit codes. - Replace
tee -awith file append redirection forgh release createoutput, and fixpackage.jsonrepository URL format.
Show a summary per file
| File | Description |
|---|---|
package.json |
Adjusts the repository.url to git+https://... per npm conventions. |
.github/workflows/publish.yml |
Updates Node version and refactors publish/release commands to preserve exit codes (and adjust summary logging). |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 2/2 changed files
- Comments generated: 1
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
josebalius
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the npm publish workflow to work correctly with OIDC-based publishing.
Successful run: https://github.com/github/copilot-engine-sdk/actions/runs/24145290995
Published package: https://www.npmjs.com/package/@github/copilot-engine-sdk
Changes
teepiping fromnpm publishcommand to avoid silent failures whereteemasks non-zero exit codestee -awith>>forgh release createto preserve exit code propagation while still appending to the step summarypackage.jsonrepository URL —npm pkg fixcorrected the URL to use thegit+https://prefix per npm conventions