Conversation
edburns
left a comment
There was a problem hiding this comment.
@copilot Your work cycle completed but the PR has zero file changes — it appears only the "Initial plan" commit was pushed.
Required work
Please implement the actual deliverable from issue #2151:
- Modify
.github/workflows/java-sdk-tests.ymlto add a newjava-sdk-inprocessjob (a separate job, NOT a matrix entry). - The new job must:
- Run on
ubuntu-latest - Set up JDK (same version as existing
java-sdkjob) - Set up Node.js (same version as existing job, needed for
npm packand replay proxy) - Run
mvn clean verify -Pinprocessfrom thejava/directory - Use the same caching, artifact upload, and failure reporting patterns as the existing job
- Run on
- The existing
java-sdkjob must remain completely unchanged.
Please re-read the full plan in 1917-java-embed-rust-cli-runtime-remove-before-merge/1917-embed-cli-runtime-ignorance-reduction-plan.md on the base branch, especially sections 3.11, 3.12, and 4.9.
Co-authored-by: edburns <75821+edburns@users.noreply.github.com>
edburns
left a comment
There was a problem hiding this comment.
@copilot The java-sdk-inprocess job is failing because many existing tests set CopilotClientOptions.Environment which throws IllegalArgumentException under InProcess transport. This is expected at this stage — the test code has not been fully adapted yet.
Fix required
Add continue-on-error: true to the java-sdk-inprocess job so it does not block the "Java required" aggregator check. The InProcess tests are informational at this stage.
java-sdk-inprocess:
name: "Java SDK InProcess Tests"
if: github.event.repository.fork == false
runs-on: ubuntu-latest
continue-on-error: trueDo NOT modify the existing java-sdk job. Only add continue-on-error: true to the java-sdk-inprocess job.
edburns
left a comment
There was a problem hiding this comment.
@copilot The CI "Java required" aggregator is failing because the java-sdk-inprocess job fails (pre-existing test incompatibility with InProcess transport).
You MUST add exactly one line to fix this. In .github/workflows/java-sdk-tests.yml, add continue-on-error: true to the java-sdk-inprocess job definition, immediately after the runs-on: ubuntu-latest line:
java-sdk-inprocess:
name: "Java SDK InProcess Tests"
if: github.event.repository.fork == false
runs-on: ubuntu-latest
continue-on-error: true
defaults:
run:
shell: bash
working-directory: ./javaThis single addition will make the InProcess job informational (non-blocking) so the aggregator passes. Push this change now.
This updates the Java SDK CI workflow to run the full Java E2E suite under both transports by adding a dedicated in-process job on Linux x64, while leaving the existing subprocess job unchanged.
Workflow update: new in-process CI job
java-sdk-inprocessjob in.github/workflows/java-sdk-tests.ymlubuntu-latestonly (hard-scoped tolinux-x64)mvn clean verify -Pinprocessfromjava/Parity with existing Java CI patterns
copilot-nativepackaging (npm pack) and Java E2E replay proxy requirementsScope guardrails preserved
java-sdksubprocess job is not modified