Forward OAuth client metadata URL in Rust sessions - #2258
Draft
SamMorrowDrums wants to merge 1 commit into
Draft
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds Rust SDK support for forwarding OAuth client metadata URLs during session creation and resume.
Changes:
- Adds optional configuration fields and builders.
- Serializes the value in create/resume wire payloads while omitting
None. - Adds serialization coverage for configured values.
Show a summary per file
| File | Description |
|---|---|
rust/src/wire.rs |
Adds optional camelCase wire fields. |
rust/src/types.rs |
Exposes, forwards, and tests the new setting. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Balanced
Comment on lines
+6414
to
+6420
| let (resume_wire, _) = ResumeSessionConfig::new(SessionId::from("sess-1")) | ||
| .with_auth_client_id_metadata_url(url) | ||
| .into_wire() | ||
| .expect("default resume has no duplicate handlers"); | ||
| let resume_json = serde_json::to_value(&resume_wire).unwrap(); | ||
| assert_eq!(resume_json["authClientIdMetadataUrl"], url); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
authClientIdMetadataUrlsession setting in the Rust SDKsession.createandsession.resumeDependencies
This dependency is needed by the GitHub Copilot desktop app consumer slice. Runtime #14687 must be available for the value to affect MCP OAuth; older runtimes ignore the additive optional request field.
Validation
cargo fmt --checkcargo test auth_client_id_metadata_url_reaches_create_and_resume_wire_payloads