Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the repository’s contribution guidelines to better set expectations for PR scope and to streamline the contributor setup/testing instructions for this multi-language Copilot SDK repo.
Changes:
- Reworked the contribution guidance to encourage issue/roadmap alignment before feature PRs.
- Restructured “What we’re looking for” and prerequisites sections.
- Simplified test/lint instructions into direct per-language commands.
Comments suppressed due to low confidence (2)
CONTRIBUTING.md:52
- The Python version requirement here (3.8+) doesn’t match the package’s declared requirement (
requires-python = ">=3.11"inpython/pyproject.toml). Please update this to 3.11+ (or whatever the repo currently supports) to avoid broken contributor setups.
1. Install [Python 3.8+](https://www.python.org/downloads/)
1. Install [uv](https://github.com/astral-sh/uv)
CONTRIBUTING.md:64
- This .NET prerequisite says “.NET 8.0+”, but the repo pins the .NET SDK via
dotnet/global.jsonto10.0.100(roll-forward major). Contributors with only the 8.0 SDK installed will fail restore/build. Please update the requirement to match the pinned SDK (or explain the minimum SDK needed).
1. Install [.NET 8.0+](https://dotnet.microsoft.com/download)
1. Install .NET dependencies: `cd dotnet && dotnet restore`
| ### All SDKs | ||
| 1. (Optional) Install [just](https://github.com/casey/just) command runner for convenience | ||
|
|
||
| 1. The end-to-end tests across all languages use a shared test harness written in Node.js. Before running tests in any language, `cd test/harness && npm ci`. |
|
|
||
| ### Node.js/TypeScript SDK | ||
|
|
||
| 1. Install [Node.js](https://nodejs.org/) (v18+) |
| @@ -63,29 +74,7 @@ This is a multi-language SDK repository. Install the tools for the SDK(s) you pl | |||
| 1. Push to your fork and [submit a pull request][pr] | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.