-
Notifications
You must be signed in to change notification settings - Fork 65.4k
Closed
Labels
invalidThis issue/PR is invalidThis issue/PR is invalidtriageDo not begin working on this issue until triaged by the teamDo not begin working on this issue until triaged by the team
Description
These look great! Just a few notes:
- Please don't eliminate the option to run
http://localhost:8080as it's handy to run the server without additional installs (caddy). - I'd suggest duplicating
localhost.config.jsonto a newrp-local.config.json. - How about
rp.localhostandidp.localhostfor shorter server name? - Let's move hardcoded IdP setting in
identity-providers.tsto config files. We can do this in another pull request, or I can work on it.
Originally posted by @agektmr in GoogleChromeLabs/project-sesame#27 (review)
Copilot
Metadata
Metadata
Assignees
Labels
invalidThis issue/PR is invalidThis issue/PR is invalidtriageDo not begin working on this issue until triaged by the teamDo not begin working on this issue until triaged by the team