Skip to content

[SEO] Redirect "Contact GitHub" footer link to Support site#4034

Merged
shati-patel merged 6 commits into
mainfrom
support
Mar 4, 2021
Merged

[SEO] Redirect "Contact GitHub" footer link to Support site#4034
shati-patel merged 6 commits into
mainfrom
support

Conversation

@skullface

Copy link
Copy Markdown
Contributor

This PR updates the redirect in place for "Contact GitHub" to minimize end-user redirects to have a positive impact on SEO.

Why:

https://github.com/github/SEO/issues/64

What's being changed:

  • Old: https://support.github.com/contact
  • New: https://support.github.com

Check off the following:

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Hey there spelunker. It looks like you've modified some files that we can't accept as contributions. The complete list of files we can't accept are:
translations/**
lib/rest/static/**
.github/workflows/**
.github/CODEOWNERS
translations/**
assets/fonts/**
data/graphql/**
lib/graphql/**
lib/redirects/**
lib/rest/**
lib/webhooks/**

You'll need to revert all of the files you changed in that list using GitHub Desktop or git checkout origin/main <file name>. Once you get those files reverted, we can continue with the review process. :octocat:

@skullface
skullface requested a review from a team February 26, 2021 19:23

@SMAKSS SMAKSS left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there, thanks for the PR, as the bot mentioned earlier the lib/redirects/* can not be modified by any PR, so AFAIK sadly no one can accept this change to the code base. Unless the core team change this by themselves.

@skullface

Copy link
Copy Markdown
Contributor Author

Thanks @SMicheal + @SMAKSS! I’ll notify the core team ^—^

@janiceilene janiceilene added the engineering Will involve Docs Engineering label Mar 1, 2021
@janiceilene

Copy link
Copy Markdown
Contributor

Thanks for opening a PR @skullface! This was discussed in Slack and can be merged in once the engineering team takes a look and gives approval 💖

@heiskr heiskr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼 Seems fine to me.

@janiceilene janiceilene added the ready to merge This pull request is ready to merge label Mar 3, 2021
@shati-patel
shati-patel enabled auto-merge (squash) March 4, 2021 14:22
@shati-patel
shati-patel dismissed github-actions[bot]’s stale review March 4, 2021 14:23

manually checked and overridden

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Hey there spelunker. It looks like you've modified some files that we can't accept as contributions. The complete list of files we can't accept are:
translations/**
lib/rest/static/**
.github/workflows/**
.github/CODEOWNERS
translations/**
assets/fonts/**
data/graphql/**
lib/graphql/**
lib/redirects/**
lib/rest/**
lib/webhooks/**

You'll need to revert all of the files you changed in that list using GitHub Desktop or git checkout origin/main <file name>. Once you get those files reverted, we can continue with the review process. :octocat:

@shati-patel
shati-patel merged commit 53dfd7f into main Mar 4, 2021
@shati-patel
shati-patel deleted the support branch March 4, 2021 14:53
@skullface skullface changed the title Redirect "Contact GitHub" footer link to Support site [SEO] Redirect "Contact GitHub" footer link to Support site Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

engineering Will involve Docs Engineering ready to merge This pull request is ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants