Skip to content

Updated GitHub Campus Program copy for Doc page#6735

Merged
jmarlena merged 4 commits into
mainfrom
bassa846-patch-2
May 27, 2021
Merged

Updated GitHub Campus Program copy for Doc page#6735
jmarlena merged 4 commits into
mainfrom
bassa846-patch-2

Conversation

@bassa846

@bassa846 bassa846 commented May 24, 2021

Copy link
Copy Markdown
Contributor

Why:

Closes #5212

What's being changed:

Check off the following:

  • I have reviewed my changes in staging (look for the deploy-to-heroku link in your pull request, then click View deployment).
  • For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

GitHub Campus Program Information for Doc page
@github-actions github-actions Bot added the triage Do not begin working on this issue until triaged by the team label May 24, 2021
@janiceilene

janiceilene commented May 25, 2021

Copy link
Copy Markdown
Contributor

This PR is looking great @bassa846! I see that it's currently in draft mode. Let me know when you're ready for writer review and I'll get it triaged 💖

@bassa846
bassa846 marked this pull request as ready for review May 25, 2021 02:41
@bassa846

Copy link
Copy Markdown
Contributor Author

@janiceilene this is ready for review.
HUGE shoutout to @jmarlena for helping me earlier 😄

@janiceilene janiceilene added waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels May 26, 2021
@jmarlena jmarlena self-assigned this May 27, 2021
jmarlena
jmarlena previously approved these changes May 27, 2021

@jmarlena jmarlena left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look great!

I just made a few suggested comments that I can apply here so this PR can ship today. 🚢

@jmarlena
jmarlena dismissed stale reviews from ghost and themself via fe520ec May 27, 2021 03:18

@jmarlena jmarlena left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All tests are green! This PR looks ready to merge. ⚡

@jmarlena
jmarlena merged commit 8ef34c8 into main May 27, 2021
@jmarlena
jmarlena deleted the bassa846-patch-2 branch May 27, 2021 03:28
@github-actions

Copy link
Copy Markdown
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

waiting for review Issue/PR is waiting for a writer's review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Content updated for GitHub Education's Docs Page

3 participants