Update packages and set >= as version operator.#77
Merged
Conversation
dgraham
approved these changes
Oct 25, 2019
| }, | ||
| "dependencies": { | ||
| "@typescript-eslint/eslint-plugin": "^1.3.0", | ||
| "@typescript-eslint/parser": "^1.3.0", |
Contributor
There was a problem hiding this comment.
The motivation for changing these two plugin versions is to remove the warning while building remote-input-element.
$ cd github/remote-input-element
$ npm run build
…
> eslint --report-unused-disable-directives . --ext .js,.ts,.tsx
=============
WARNING: You are currently running a version of TypeScript which is not officially supported by typescript-estree.
You may find that it works just fine, or you may not.
SUPPORTED TYPESCRIPT VERSIONS: >=3.2.1 <3.6.0
YOUR TYPESCRIPT VERSION: 3.6.4
Please only submit bug reports when using the officially supported version.
=============
> tsc --noEmit
josh
approved these changes
Oct 28, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should mean that we don't have to bump these and cut a release. The applications using the plugin should be able to update to whatever version of these sub-dependencies that they want.
Should there even be a
package-lock.json?