Skip to content

Add --include-from option to GitHub forecast - #220

Merged
ethanis merged 1 commit into
mainfrom
add-include-from-option-to-GH-forecast
Jul 27, 2023
Merged

Add --include-from option to GitHub forecast#220
ethanis merged 1 commit into
mainfrom
add-include-from-option-to-GH-forecast

Conversation

@Chaseshak

@Chaseshak Chaseshak commented Jul 26, 2023

Copy link
Copy Markdown
Contributor

What's changing?

  • Add the --include-from option to support splitting GitHub forecasts across multiple machines/CLI invocations.

How's this tested?

  • Run dotnet run --project src/ActionsImporter/ActionsImporter.csproj -- forecast github --help and see that the new --include-from option is included and matches the one in github/valet#6672

Closes github/valet#6618

@github-actions

Copy link
Copy Markdown

Unit Test Results

41 tests  ±0   41 ✔️ ±0   0s ⏱️ ±0s
  1 suites ±0     0 💤 ±0 
  1 files   ±0     0 ±0 

Results for commit 654caf8. ± Comparison against base commit 93163ee.

@Chaseshak
Chaseshak marked this pull request as ready for review July 26, 2023 21:48
@Chaseshak
Chaseshak requested a review from a team as a code owner July 26, 2023 21:48

@luke-engle luke-engle left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢

@ethanis
ethanis merged commit 4f62f5f into main Jul 27, 2023
@ethanis
ethanis deleted the add-include-from-option-to-GH-forecast branch July 27, 2023 00:48
Kimmie234 added a commit to Kimmie234/gh-actions-importer that referenced this pull request Aug 2, 2023

@jonesk7734 jonesk7734 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants