Skip to content

Remove internal-only interfaces and inline return types in src/cli.ts #2435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lpcox merged 3 commits into from
May 3, 2026
Merged

Remove internal-only interfaces and inline return types in src/cli.ts #2435

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a6fb87f
Initial plan
Copilot May 3, 2026
4a7754c
Remove export keyword from internal interfaces in src/cli.ts
Copilot May 3, 2026
4092ebb
refactor(cli): inline return types; remove named interfaces
Copilot May 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 8 additions & 31 deletions src/cli.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1092,39 +1092,14 @@ export function joinShellArgs(args: string[]): string {
return args.map(escapeShellArg).join(' ');
}

/**
* Result of parsing environment variables
*/
export interface ParseEnvResult {
success: true;
env: Record<string, string>;
}

export interface ParseEnvError {
success: false;
invalidVar: string;
}

/**
* Result of parsing volume mounts
*/
export interface ParseVolumeMountsResult {
success: true;
mounts: string[];
}

export interface ParseVolumeMountsError {
success: false;
invalidMount: string;
reason: string;
}

/**
* Parses environment variables from an array of KEY=VALUE strings
* @param envVars Array of environment variable strings in KEY=VALUE format
* @returns ParseEnvResult with parsed key-value pairs on success, or ParseEnvError with the invalid variable on failure
* @returns Object with parsed key-value pairs on success, or error details on failure
*/
export function parseEnvironmentVariables(envVars: string[]): ParseEnvResult | ParseEnvError {
export function parseEnvironmentVariables(
envVars: string[]
): { success: true; env: Record<string, string> } | { success: false; invalidVar: string } {
const result: Record<string, string> = {};

for (const envVar of envVars) {
Expand All @@ -1142,9 +1117,11 @@ export function parseEnvironmentVariables(envVars: string[]): ParseEnvResult | P
/**
* Parses and validates volume mount specifications
* @param mounts Array of volume mount strings in host_path:container_path[:mode] format
* @returns ParseVolumeMountsResult on success, or ParseVolumeMountsError with details on failure
* @returns Object with parsed mount strings on success, or error details on failure
*/
export function parseVolumeMounts(mounts: string[]): ParseVolumeMountsResult | ParseVolumeMountsError {
export function parseVolumeMounts(
mounts: string[]
): { success: true; mounts: string[] } | { success: false; invalidMount: string; reason: string } {
const result: string[] = [];

for (const mount of mounts) {
Expand Down
Loading