Stabilize test-coverage-reporter by isolating main-action unit tests from DinD probing#3595
Conversation
✅ Coverage Check PassedOverall Coverage
📁 Per-file Coverage Changes (1 files)
Coverage comparison generated by |
There was a problem hiding this comment.
Pull request overview
Stabilizes the createMainAction unit test suite by preventing main-action.test.ts from executing real DinD split-filesystem probe logic (which can introduce Docker-dependent latency/timeouts in CI).
Changes:
- Mocked
../dind-probeinmain-action.test.tsto avoid invoking real probe behavior. - Added a default
beforeEachstub forprobeSplitFilesystemreturning a deterministic “no split detected” result.
Show a summary per file
| File | Description |
|---|---|
| src/commands/main-action.test.ts | Mocks DinD probe module and provides a default resolved probe result to keep createMainAction tests deterministic and fast. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 0
Smoke Test Results✅ GitHub API: Recent PRs verified (2 entries) Overall: PASS
|
Smoke Test Results✅ GitHub MCP: Status: FAIL CC:
|
BYOK Smoke Test ResultsRunning in offline BYOK mode (
Status: PARTIAL FAIL (2/4 tests passed)
|
Smoke Test Results
Overall status: FAIL Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
network:
allowed:
- defaults
- "localhost"See Network Configuration for more information.
|
Chroot Runtime Version ComparisonResults from testing runtime versions between host and chroot environments:
Overall Status: ❌ Not all versions match Details
The chroot environment successfully exposes host binaries, but version mismatches indicate the container may be using different system paths or the bind mounts may not be covering all necessary directories.
|
|
Smoke Codex: FAIL Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
network:
allowed:
- defaults
- "registry.npmjs.org"See Network Configuration for more information.
|
Smoke Test: Services Connectivity — ❌ FAIL
Overall: FAIL — Services not reachable from AWF sandbox
|
🏗️ Build Test Suite ResultsAll build tests completed successfully!
Overall: 8/8 ecosystems passed — ✅ PASS Summary
All language ecosystems successfully built and tested within the AWF firewall environment.
|
Test Coverage Reporterfailed onmainbecausenpm run test:coverageintermittently timed out insrc/commands/main-action.test.ts. The suite was executing real split-filesystem probe behavior, introducing Docker-dependent latency into a unit test path.Root cause
createMainActionnow awaitsprobeSplitFilesystem(...).main-action.test.tsdid not mock../dind-probe, so tests could invoke real probe logic and become timing-sensitive in CI.Changes made
createMainActionjest.mock('../dind-probe').beforeEachmock forprobeSplitFilesystemto return a deterministic non-split result.src/commands/main-action.test.ts; no runtime/workflow behavior changes.Example