Skip to content

refactor: use pickEnvVars for OTEL environment variable forwarding #3752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lpcox merged 1 commit into from
May 25, 2026
Merged

refactor: use pickEnvVars for OTEL environment variable forwarding #3752

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 6 additions & 12 deletions src/services/api-proxy-service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,19 +125,13 @@ export function buildApiProxyService(params: ApiProxyServiceParams): ApiProxyBui
// parent trace context so api-proxy spans are children of the workflow trace.
// OTEL_EXPORTER_OTLP_ENDPOINT activates OTLP/HTTP export (via Squid); when absent
// spans are written to /var/log/api-proxy/otel.jsonl as a local file fallback.
...(process.env.OTEL_EXPORTER_OTLP_ENDPOINT && {
OTEL_EXPORTER_OTLP_ENDPOINT: process.env.OTEL_EXPORTER_OTLP_ENDPOINT,
}),
...(process.env.OTEL_EXPORTER_OTLP_HEADERS && {
OTEL_EXPORTER_OTLP_HEADERS: process.env.OTEL_EXPORTER_OTLP_HEADERS,
}),
...pickEnvVars(
'OTEL_EXPORTER_OTLP_ENDPOINT',
'OTEL_EXPORTER_OTLP_HEADERS',
'GITHUB_AW_OTEL_TRACE_ID',
'GITHUB_AW_OTEL_PARENT_SPAN_ID',
),
OTEL_SERVICE_NAME: process.env.OTEL_SERVICE_NAME || 'awf-api-proxy',
...(process.env.GITHUB_AW_OTEL_TRACE_ID && {
GITHUB_AW_OTEL_TRACE_ID: process.env.GITHUB_AW_OTEL_TRACE_ID,
}),
...(process.env.GITHUB_AW_OTEL_PARENT_SPAN_ID && {
GITHUB_AW_OTEL_PARENT_SPAN_ID: process.env.GITHUB_AW_OTEL_PARENT_SPAN_ID,
}),
// Rate limiting configuration
...(config.rateLimitConfig && {
AWF_RATE_LIMIT_ENABLED: String(config.rateLimitConfig.enabled),
Expand Down
Loading