Skip to content

refactor(tests): extract useAgentVolumesTestConfig to eliminate duplicated setup boilerplate #4263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lpcox merged 3 commits into from
Jun 3, 2026
Merged

refactor(tests): extract useAgentVolumesTestConfig to eliminate duplicated setup boilerplate #4263

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f160980
Initial plan
Copilot Jun 3, 2026
905c550
refactor(tests): extract useAgentVolumesTestConfig helper
Copilot Jun 3, 2026
ebe6a02
test: address review feedback on agent volume setup helper
Copilot Jun 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 8 additions & 16 deletions src/services/agent-volumes-logs.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,25 +1,17 @@
import { generateDockerCompose, WrapperConfig, baseConfig, mockNetworkConfig, useTempWorkDir } from './service-test-setup.test-utils';
import { generateDockerCompose, WrapperConfig, mockNetworkConfig, useAgentVolumesTestConfig } from './service-test-setup.test-utils';

// Create mock functions (must remain per-file — jest.mock() is hoisted before imports)

// eslint-disable-next-line @typescript-eslint/no-require-imports
jest.mock('execa', () => require('../test-helpers/mock-execa.test-utils').execaMockFactory());

let mockConfig: WrapperConfig;
const { getConfig } = useAgentVolumesTestConfig();

describe('agent service', () => {
useTempWorkDir(
baseConfig,
(config) => {
mockConfig = config;
},
() => mockConfig
);

describe('proxyLogsDir option', () => {
it('should use proxyLogsDir when specified', () => {
const config: WrapperConfig = {
...mockConfig,
...getConfig(),
proxyLogsDir: '/custom/proxy/logs',
};
const result = generateDockerCompose(config, mockNetworkConfig);
Expand All @@ -29,15 +21,15 @@ describe('agent service', () => {
});

it('should use workDir/squid-logs when proxyLogsDir is not specified', () => {
const result = generateDockerCompose(mockConfig, mockNetworkConfig);
const result = generateDockerCompose(getConfig(), mockNetworkConfig);
const squid = result.services['squid-proxy'];

expect(squid.volumes).toContain(`${mockConfig.workDir}/squid-logs:/var/log/squid:rw`);
expect(squid.volumes).toContain(`${getConfig().workDir}/squid-logs:/var/log/squid:rw`);
});

it('should use api-proxy-logs subdirectory inside proxyLogsDir when specified', () => {
const config: WrapperConfig = {
...mockConfig,
...getConfig(),
proxyLogsDir: '/custom/proxy/logs',
enableApiProxy: true,
openaiApiKey: 'sk-test-key',
Expand All @@ -53,7 +45,7 @@ describe('agent service', () => {

it('should use workDir/api-proxy-logs when proxyLogsDir is not specified', () => {
const config: WrapperConfig = {
...mockConfig,
...getConfig(),
enableApiProxy: true,
openaiApiKey: 'sk-test-key',
};
Expand All @@ -63,7 +55,7 @@ describe('agent service', () => {
});
const apiProxy = result.services['api-proxy'];

expect(apiProxy.volumes).toContain(`${mockConfig.workDir}/api-proxy-logs:/var/log/api-proxy:rw`);
expect(apiProxy.volumes).toContain(`${getConfig().workDir}/api-proxy-logs:/var/log/api-proxy:rw`);
});
});
});
Loading
Loading