Skip to content

fix(entrypoint): bind-mount passwd/group synthesis fallback for read-only /host/etc (ARC/DinD) #4831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lpcox merged 7 commits into from
Jun 13, 2026
Merged

fix(entrypoint): bind-mount passwd/group synthesis fallback for read-only /host/etc (ARC/DinD) #4831

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
48b01e1
Initial plan
Copilot Jun 12, 2026
dd6ae12
fix: use bind-mount fallback when /host/etc is read-only in ARC/DinD
Copilot Jun 12, 2026
5e97aa0
Potential fix for pull request finding
lpcox Jun 12, 2026
6eca8b1
Potential fix for pull request finding
lpcox Jun 12, 2026
3e3efb7
fix(deps): upgrade esbuild to ^0.28.1 to remediate GHSA-gv7w-rqvm-qjhr
Copilot Jun 12, 2026
6198f9a
fix(docs-site): resolve high-severity npm audit vulnerabilities
lpcox Jun 13, 2026
b91997a
Merge remote-tracking branch 'origin/main' into copilot/fix-passwd-sy…
Copilot Jun 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 25 additions & 2 deletions containers/agent/entrypoint.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -767,7 +767,20 @@ if [ "${AWF_CHROOT_ENABLED}" = "true" ]; then
if echo "${PASSWD_ENTRY}" >> /host/etc/passwd 2>/dev/null; then
echo "[entrypoint] Appended ${HOST_USER} (UID ${HOST_USER_UID}) to /host/etc/passwd"
else
echo "[entrypoint][WARN] Could not write to /host/etc/passwd — identity resolution may fail"
# /host/etc is read-only (e.g. ARC/DinD with tmpfs-backed daemon root).
# Copy the existing file to a writable tmpfs location, append the new entry,
# then bind-mount the copy over the read-only original. SYS_ADMIN is still
# available at this point (it is dropped by capsh before user code runs).
SYNTH_ETC_DIR="/tmp/awf-etc"
if mkdir -p "${SYNTH_ETC_DIR}" 2>/dev/null \
&& cp /host/etc/passwd "${SYNTH_ETC_DIR}/passwd" 2>/dev/null \
&& echo "${PASSWD_ENTRY}" >> "${SYNTH_ETC_DIR}/passwd" 2>/dev/null \
&& chmod 644 "${SYNTH_ETC_DIR}/passwd" 2>/dev/null \
&& mount --bind "${SYNTH_ETC_DIR}/passwd" /host/etc/passwd 2>/dev/null; then
echo "[entrypoint] Bind-mounted synthesized /host/etc/passwd over read-only original"
else
echo "[entrypoint][WARN] Could not write or bind-mount /host/etc/passwd — identity resolution may fail"
fi
Comment thread
Copilot marked this conversation as resolved.
fi
else
# Create minimal passwd with root and the runner user
Expand All @@ -787,7 +800,17 @@ if [ "${AWF_CHROOT_ENABLED}" = "true" ]; then
if echo "${GROUP_ENTRY}" >> /host/etc/group 2>/dev/null; then
echo "[entrypoint] Appended group ${SYNTH_GROUP_NAME} (GID ${HOST_USER_GID}) to /host/etc/group"
else
echo "[entrypoint][WARN] Could not write to /host/etc/group"
# /host/etc is read-only — same bind-mount fallback as for passwd above.
SYNTH_ETC_DIR="/tmp/awf-etc"
if mkdir -p "${SYNTH_ETC_DIR}" 2>/dev/null \
&& cp /host/etc/group "${SYNTH_ETC_DIR}/group" 2>/dev/null \
&& echo "${GROUP_ENTRY}" >> "${SYNTH_ETC_DIR}/group" 2>/dev/null \
&& chmod 644 "${SYNTH_ETC_DIR}/group" 2>/dev/null \
&& mount --bind "${SYNTH_ETC_DIR}/group" /host/etc/group 2>/dev/null; then
echo "[entrypoint] Bind-mounted synthesized /host/etc/group over read-only original"
else
echo "[entrypoint][WARN] Could not write or bind-mount /host/etc/group — identity resolution may fail"
fi
Comment thread
Copilot marked this conversation as resolved.
fi
else
if printf '%s\n' "root:x:0:" "nobody:x:65534:" "${GROUP_ENTRY}" > /host/etc/group 2>/dev/null; then
Expand Down
Loading
Loading