Skip to content

Clarify non-PR behavior in AOAI Entra smoke workflow to prevent missing_data failures#4875

Merged
lpcox merged 6 commits into
mainfrom
copilot/fix-missing-data-report
Jun 13, 2026
Merged

Clarify non-PR behavior in AOAI Entra smoke workflow to prevent missing_data failures#4875
lpcox merged 6 commits into
mainfrom
copilot/fix-missing-data-report

Conversation

Copilot AI commented Jun 13, 2026

Copy link
Copy Markdown
Contributor

Scheduled/manual runs of smoke-copilot-byok-aoai-entra were still instructing the agent to post PR outputs, causing missing_data (pull_request_number) when no PR context exists. This change makes trigger-specific output behavior explicit so non-PR runs complete via noop instead of failing metadata checks.

  • Prompt contract update (workflow source)

    • Updated .github/workflows/smoke-copilot-byok-aoai-entra.md output instructions to branch by trigger type:
      • pull_request: post comment + apply label
      • workflow_dispatch / schedule: emit noop PASS/FAIL summary and skip PR-only actions
  • Regression coverage

    • Added scripts/ci/smoke-copilot-byok-aoai-entra-workflow.test.ts to enforce presence of:
      • PR-only output instructions
      • non-PR noop fallback
      • explicit prohibition on PR comment/label actions without PR context
**If triggered by workflow_dispatch or schedule** (no PR context), call `noop` with a concise PASS/FAIL summary instead. Do NOT attempt to add pull request comments or labels when there is no pull request.

Copilot AI changed the title [WIP] Fix missing data reported in smoke Copilot BYOK AOAI workflow Clarify non-PR behavior in AOAI Entra smoke workflow to prevent missing_data failures Jun 13, 2026
Copilot finished work on behalf of lpcox June 13, 2026 14:39
Copilot AI requested a review from lpcox June 13, 2026 14:39
@lpcox lpcox marked this pull request as ready for review June 13, 2026 15:40
Copilot AI review requested due to automatic review settings June 13, 2026 15:40
@github-actions

github-actions Bot commented Jun 13, 2026

Copy link
Copy Markdown
Contributor

✅ Coverage Check Passed

Overall Coverage

Metric Base PR Delta
Lines 96.60% 96.64% 📈 +0.04%
Statements 96.47% 96.51% 📈 +0.04%
Functions 98.78% 98.78% ➡️ +0.00%
Branches 91.22% 91.25% 📈 +0.03%
📁 Per-file Coverage Changes (1 files)
File Lines (Before → After) Statements (Before → After)
src/config-writer.ts 89.9% → 91.1% (+1.19%) 89.9% → 91.1% (+1.19%)

Coverage comparison generated by scripts/ci/compare-coverage.ts

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the smoke-copilot-byok-aoai-entra smoke workflow prompt contract to explicitly handle non-PR triggers (schedule / workflow_dispatch) by emitting a noop summary instead of attempting PR-only actions that can fail due to missing PR metadata, and adds a regression test to enforce the prompt wording.

Changes:

  • Updated Output instructions in .github/workflows/smoke-copilot-byok-aoai-entra.md to branch behavior by trigger type (PR vs non-PR).
  • Added scripts/ci/smoke-copilot-byok-aoai-entra-workflow.test.ts to assert the presence of PR-only instructions and the non-PR noop fallback.
Show a summary per file
File Description
scripts/ci/smoke-copilot-byok-aoai-entra-workflow.test.ts Adds a Jest test to enforce trigger-specific Output instructions in the workflow source prompt.
.github/workflows/smoke-copilot-byok-aoai-entra.md Clarifies Output behavior for PR vs non-PR runs to prevent missing-data failures on non-PR triggers.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 2/2 changed files
  • Comments generated: 3

Comment thread .github/workflows/smoke-copilot-byok-aoai-entra.md Outdated
Comment thread .github/workflows/smoke-copilot-byok-aoai-entra.md Outdated
Comment thread scripts/ci/smoke-copilot-byok-aoai-entra-workflow.test.ts Outdated
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

lpcox and others added 2 commits June 13, 2026 08:55
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@github-actions

This comment has been minimized.

@github-actions

Copy link
Copy Markdown
Contributor

@lpcox

  • MCP list pull requests: ✅
  • github.com connectivity: ✅
  • File write/read: ✅
  • Running in direct BYOK mode (COPILOT_PROVIDER_API_KEY + COPILOT_PROVIDER_BASE_URL) via api-proxy → Azure OpenAI (Foundry, o4-mini-aw): ✅

Overall status: PASS

🔑 BYOK (AOAI api-key) report filed by Smoke Copilot BYOK AOAI (api-key)

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@lpcox

lpcox commented Jun 13, 2026

Copy link
Copy Markdown
Collaborator

@copilot resolve the merge conflicts in this pull request

Copilot AI commented Jun 13, 2026

Copy link
Copy Markdown
Contributor Author

@copilot resolve the merge conflicts in this pull request

Merge conflicts resolved in 0b40ccc. The single conflicted file (.github/workflows/smoke-copilot-byok-aoai-entra.md) had two wording conflicts in the Output section — both accepted the origin/main version, which uses the explicit add_labels safe-output tool bullet format requested by the reviewer. The per-workflow test file (smoke-copilot-byok-aoai-entra-workflow.test.ts) was removed since origin/main introduced smoke-copilot-workflow.test.ts covering all five copilot smoke workflows with updated assertions.

@github-actions

Copy link
Copy Markdown
Contributor

🤖 Smoke Test Results — PASS

Test Result
GitHub MCP (list PRs)
GitHub.com connectivity (HTTP 200)
File write/read

Overall: ✅ PASS

cc @Copilot @lpcox

📰 BREAKING: Report filed by Smoke Copilot

@github-actions

Copy link
Copy Markdown
Contributor

🔬 Smoke Test: Copilot PAT Auth — PR #4875

Test Result
GitHub MCP connectivity
GitHub.com HTTP ❓ pre-step outputs unresolved
File write/read ❓ pre-step outputs unresolved

Overall: FAIL — pre-step template variables (${{ steps.smoke-data.outputs.* }}) were not substituted before reaching the agent.

Auth mode: PAT (COPILOT_GITHUB_TOKEN) | PR by @Copilot, assigned to @lpcox @Copilot

🔑 PAT report filed by Smoke Copilot PAT

@github-actions

Copy link
Copy Markdown
Contributor

Smoke Test: Copilot BYOK (Direct) Mode ✅ PASS

  • ✅ MCP connectivity (github-list_pull_requests)
  • ✅ GitHub.com connectivity (HTTP 200)
  • ✅ File write/read test
  • ✅ BYOK inference (api-proxy → api.githubcopilot.com)

Running in direct BYOK mode (COPILOT_PROVIDER_API_KEY via api-proxy sidecar). All tests passed.

🔑 BYOK report filed by Smoke Copilot BYOK

@github-actions

Copy link
Copy Markdown
Contributor

Smoke test results:

  • fix(dispatcher): eliminate AI credits overrun with DataOps pre-fetch and hard guardrails ✅
  • fix: add noop fallback to smoke-copilot workflows on non-PR triggers ✅
  • GitHub review: ✅
  • safeinputs-gh query: ⚠️ unavailable here; used public API/browser fallback
  • Playwright title: ✅
  • File write/read: ✅
  • Discussion comment: ✅
  • Build (npm ci && npm run build): ❌ (node missing)
    Overall: FAIL

🔮 The oracle has spoken through Smoke Codex

@github-actions

Copy link
Copy Markdown
Contributor

🏗️ Build Test Suite Results

Ecosystem Project Build/Install Tests Status
Bun elysia 1/1 passed ✅ PASS
Bun hono 1/1 passed ✅ PASS
C++ fmt N/A ✅ PASS
C++ json N/A ✅ PASS
Deno oak N/A 1/1 passed ✅ PASS
Deno std N/A 1/1 passed ✅ PASS
.NET hello-world N/A ✅ PASS
.NET json-parse N/A ✅ PASS
Go color ok ✅ PASS
Go env ok ✅ PASS
Go uuid ok ✅ PASS
Java gson 1/1 passed ✅ PASS
Java caffeine 1/1 passed ✅ PASS
Node.js clsx All passed ✅ PASS
Node.js execa All passed ✅ PASS
Node.js p-limit All passed ✅ PASS
Rust fd 1/1 passed ✅ PASS
Rust zoxide 1/1 passed ✅ PASS

Overall: 8/8 ecosystems passed — ✅ PASS

Generated by Build Test Suite for issue #4875 ·

@github-actions

Copy link
Copy Markdown
Contributor

@Copilot @lpcox

  1. MCP: fix(workflow): use gpt-5.4-mini and raise max-ai-credits for copilot-token-usage-analyzer ✅
  2. HTTP: ✅
  3. File I/O: ✅
  4. BYOK: ✅

Mode: direct BYOK via api-proxy → Azure OpenAI (Foundry) authenticated via Microsoft Entra
Overall: PASS

🪪 BYOK (AOAI Entra) report filed by Smoke Copilot BYOK AOAI (Entra)

@github-actions

Copy link
Copy Markdown
Contributor

Smoke Test: GitHub Actions Services Connectivity

Check Result
Redis PING ❌ Connection timed out (no PONG)
PostgreSQL pg_isready ❌ No response
PostgreSQL SELECT 1 ❌ Failed (no response)

host.docker.internal resolves to 172.17.0.1 but ports 6379 and 5432 are unreachable (TCP timeout).

Overall: ❌ FAIL — service containers are not accessible from this environment.

🔌 Service connectivity validated by Smoke Services

@lpcox lpcox merged commit 912ef8a into main Jun 13, 2026
46 of 50 checks passed
@lpcox lpcox deleted the copilot/fix-missing-data-report branch June 13, 2026 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants