Clarify non-PR behavior in AOAI Entra smoke workflow to prevent missing_data failures#4875
Conversation
✅ Coverage Check PassedOverall Coverage
📁 Per-file Coverage Changes (1 files)
Coverage comparison generated by |
There was a problem hiding this comment.
Pull request overview
This PR updates the smoke-copilot-byok-aoai-entra smoke workflow prompt contract to explicitly handle non-PR triggers (schedule / workflow_dispatch) by emitting a noop summary instead of attempting PR-only actions that can fail due to missing PR metadata, and adds a regression test to enforce the prompt wording.
Changes:
- Updated Output instructions in
.github/workflows/smoke-copilot-byok-aoai-entra.mdto branch behavior by trigger type (PR vs non-PR). - Added
scripts/ci/smoke-copilot-byok-aoai-entra-workflow.test.tsto assert the presence of PR-only instructions and the non-PRnoopfallback.
Show a summary per file
| File | Description |
|---|---|
| scripts/ci/smoke-copilot-byok-aoai-entra-workflow.test.ts | Adds a Jest test to enforce trigger-specific Output instructions in the workflow source prompt. |
| .github/workflows/smoke-copilot-byok-aoai-entra.md | Clarifies Output behavior for PR vs non-PR runs to prevent missing-data failures on non-PR triggers. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 2/2 changed files
- Comments generated: 3
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This comment has been minimized.
This comment has been minimized.
|
Overall status: PASS
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@copilot resolve the merge conflicts in this pull request |
Merge conflicts resolved in 0b40ccc. The single conflicted file ( |
🤖 Smoke Test Results — PASS
Overall: ✅ PASS cc
|
🔬 Smoke Test: Copilot PAT Auth — PR #4875
Overall: FAIL — pre-step template variables ( Auth mode: PAT (COPILOT_GITHUB_TOKEN) | PR by
|
|
Smoke Test: Copilot BYOK (Direct) Mode ✅ PASS
Running in direct BYOK mode (COPILOT_PROVIDER_API_KEY via api-proxy sidecar). All tests passed.
|
|
Smoke test results:
|
🏗️ Build Test Suite Results
Overall: 8/8 ecosystems passed — ✅ PASS
|
|
Mode: direct BYOK via api-proxy → Azure OpenAI (Foundry) authenticated via Microsoft Entra
|
Smoke Test: GitHub Actions Services Connectivity
Overall: ❌ FAIL — service containers are not accessible from this environment.
|
Scheduled/manual runs of
smoke-copilot-byok-aoai-entrawere still instructing the agent to post PR outputs, causingmissing_data(pull_request_number) when no PR context exists. This change makes trigger-specific output behavior explicit so non-PR runs complete vianoopinstead of failing metadata checks.Prompt contract update (workflow source)
.github/workflows/smoke-copilot-byok-aoai-entra.mdoutput instructions to branch by trigger type:pull_request: post comment + apply labelworkflow_dispatch/schedule: emitnoopPASS/FAIL summary and skip PR-only actionsRegression coverage
scripts/ci/smoke-copilot-byok-aoai-entra-workflow.test.tsto enforce presence of:noopfallback