fix: recognize copilot-pull-request-reviewer in ci-gate by lpcox · Pull Request #5068 · github/gh-aw-firewall

lpcox · 2026-06-15T22:37:22Z

The Copilot review bot uses login copilot-pull-request-reviewer, which was missing from the ci-gate's reviewer set. This caused the gate to never recognize Copilot's review and never add the ready-for-ci label.

One-line fix: add 'copilot-pull-request-reviewer' to the Set.

The Copilot review bot uses the login 'copilot-pull-request-reviewer', which was not in the reviewer set. This caused the ci-gate to fail to add the ready-for-ci label after Copilot review. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Updates the CI gate workflow to correctly recognize reviews from the Copilot review bot account so the ready-for-ci label can be applied when appropriate.

Changes:

Add copilot-pull-request-reviewer to the copilotReviewers allowlist in the ci-gate workflow.

Show a summary per file

File	Description
.github/workflows/ci-gate.yml	Expands the recognized Copilot reviewer login set used to decide when to apply `ready-for-ci`.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Files reviewed: 1/1 changed files
Comments generated: 1

        with:
          script: |
-            const copilotReviewers = new Set(['copilot', 'copilot[bot]', 'Copilot']);
+            const copilotReviewers = new Set(['copilot', 'copilot[bot]', 'Copilot', 'copilot-pull-request-reviewer']);


lpcox · 2026-06-15T22:38:54Z

@copilot address review feedback

Copilot · 2026-06-15T22:42:28Z

@copilot address review feedback

Addressed in commit 6aa0db4 by updating scripts/ci/ready-for-ci-workflows.test.ts to match the expanded copilotReviewers set, and verified with npm test -- scripts/ci/ready-for-ci-workflows.test.ts.

github-actions · 2026-06-15T22:43:31Z

✅ Coverage Check Passed

Overall Coverage

Metric	Base	PR	Delta
Lines	96.89%	96.93%	📈 +0.04%
Statements	96.75%	96.79%	📈 +0.04%
Functions	98.81%	98.81%	➡️ +0.00%
Branches	91.26%	91.29%	📈 +0.03%

📁 Per-file Coverage Changes (1 files)

File	Lines (Before → After)	Statements (Before → After)
`src/workdir-setup.ts`	92.6% → 94.4% (+1.85%)	92.6% → 94.4% (+1.85%)

Coverage comparison generated by scripts/ci/compare-coverage.ts

github-actions · 2026-06-15T22:48:13Z

🔑 Smoke Copilot PAT PAT auth validated. All systems operational. ✅

github-actions · 2026-06-15T22:48:14Z

📡 Smoke OTel Tracing completed. All tracing scenarios validated. ✅

github-actions · 2026-06-15T22:48:40Z

✅ Smoke Copilot BYOK AOAI (Entra) completed. Copilot AOAI BYOK (Entra) mode operational. 🔓

github-actions · 2026-06-15T22:48:40Z

🌑 The shadows whisper... Smoke Codex failed. The oracle requires further meditation...

github-actions · 2026-06-15T22:48:41Z

✅ Smoke Copilot BYOK completed. Copilot BYOK mode operational. 🔓

github-actions · 2026-06-15T22:48:42Z

🔌 Smoke Services — All services reachable! ✅

github-actions · 2026-06-15T22:48:45Z

✅ Build Test Suite completed successfully!

github-actions · 2026-06-15T22:48:48Z

📰 VERDICT: Smoke Copilot has concluded. All systems operational. This is a developing story. 🎤

github-actions · 2026-06-15T22:48:48Z

❌ Contribution Check failed. Please review the logs for details.

github-actions · 2026-06-15T22:48:49Z

❌ Smoke Claude failed

github-actions · 2026-06-15T22:48:51Z

🚀 Security Guard has started processing this pull request

github-actions · 2026-06-15T22:49:00Z

Chroot tests passed! Smoke Chroot - All security and functionality tests succeeded.

github-actions · 2026-06-15T22:49:02Z

✅ Smoke Copilot BYOK AOAI (api-key) completed. Copilot AOAI BYOK (api-key) mode operational. 🔓

github-actions · 2026-06-15T22:49:06Z

✅ Smoke Gemini completed. All facets verified. 💎

Smoke test completed with partial failures. Results reported to PR #5068.

github-actions · 2026-06-15T22:51:43Z

🔥 Smoke Test Results — Auth mode: PAT (COPILOT_GITHUB_TOKEN)

Test	Result
GitHub MCP connectivity	✅
github.com HTTP (200)	✅
File write/read	✅

Overall: PASS

/cc @lpcox

🔑 PAT report filed by Smoke Copilot PAT

github-actions · 2026-06-15T22:52:10Z

🔥 Smoke Test Results — PASS

Test	Status
GitHub MCP connectivity	✅
github.com HTTP	✅ 200
File write/read	✅

PR: fix: recognize copilot-pull-request-reviewer in ci-gate
Author: @lpcox

Overall: PASS

📰 BREAKING: Report filed by Smoke Copilot

github-actions · 2026-06-15T22:52:17Z

Copilot BYOK Smoke Test: PASS ✅

✅ MCP GitHub connectivity (PR listing works)
✅ GitHub.com accessibility (HTTP 200)
✅ File I/O (smoke test data readable)
✅ BYOK inference active (direct COPILOT_PROVIDER_API_KEY mode)

Running via api-proxy sidecar → api.githubcopilot.com (real credentials held by sidecar, agent sees placeholder only).

@lpcox

🔑 BYOK report filed by Smoke Copilot BYOK

github-actions · 2026-06-15T22:52:31Z

@lpcox

MCP PR fetch: ✅
GitHub.com connectivity: ✅
File write/read: ✅
BYOK inference: ✅
Running in direct BYOK mode (AWF_AUTH_TYPE=github-oidc + AWF_AUTH_AZURE_* + COPILOT_PROVIDER_BASE_URL) via api-proxy → Azure OpenAI (Foundry, o4-mini-aw) authenticated via Microsoft Entra
Overall: PASS

🪪 BYOK (AOAI Entra) report filed by Smoke Copilot BYOK AOAI (Entra)

github-actions · 2026-06-15T22:53:13Z

📡 OTel Tracing Smoke Test Results

Scenario	Result	Detail
1: Module Loading	✅	`otel.js` loads; exports `startRequestSpan`, `setTokenAttributes`, `setBudgetAttributes`, `endSpan`, `endSpanError`, `shutdown`, `isEnabled`; `isEnabled: true` (file fallback active)
2: Test Suite	✅	59/59 tests passed across 2 suites (`otel.test.js`, `otel-fanout.test.js`)
3: Env Var Forwarding	⚠️	Check looks in `api-proxy-service.ts` but forwarding is implemented in `api-proxy-service-config.ts` — `GH_AW_OTLP_ENDPOINTS`, `OTEL_EXPORTER_OTLP_ENDPOINT`, `GITHUB_AW_OTEL_TRACE_ID`, `GITHUB_AW_OTEL_PARENT_SPAN_ID` are all forwarded
4: Token Tracker Integration	✅	`onUsage` callback confirmed in `token-tracker-http.js` (lines 176, 251, 320)
5: OTEL Diagnostics	⚠️	No spans exported — expected, smoke test makes no real LLM API calls through api-proxy

All scenarios pass or are expected-pending. No regressions detected.

📡 OTel tracing validated by Smoke OTel Tracing

github-actions · 2026-06-15T22:53:39Z

Chroot Version Comparison Results

Runtime	Host Version	Chroot Version	Match?
Python	Python 3.12.13	Python 3.12.3	❌ NO
Node.js	v24.16.0	v22.22.3	❌ NO
Go	go1.22.12	go1.22.12	✅ YES

Overall: ❌ FAILED — Python and Node.js versions differ between host and chroot environment.

Tested by Smoke Chroot

github-actions · 2026-06-15T22:53:48Z

@lpcox

fix: recognize copilot-pull-request-reviewer in ci-gate: ✅
GitHub.com connectivity: ✅
File write/read: ✅
BYOK inference: ✅

Running in direct BYOK mode (COPILOT_PROVIDER_API_KEY + COPILOT_PROVIDER_BASE_URL) via api-proxy → Azure OpenAI (Foundry, o4-mini-aw)
Overall: PASS

🔑 BYOK (AOAI api-key) report filed by Smoke Copilot BYOK AOAI (api-key)

manamansor

Open

github-actions · 2026-06-15T22:54:50Z

Smoke Test: GitHub Actions Services Connectivity

Check	Result
Redis PING (`host.docker.internal:6379`)	❌ no response (timeout)
PostgreSQL pg_isready (`:5432`)	❌ no response
PostgreSQL SELECT 1	❌ no response (timeout)

Overall: FAIL — host.docker.internal service containers are unreachable from this runner.

🔌 Service connectivity validated by Smoke Services

github-actions · 2026-06-15T22:55:00Z

🏗️ Build Test Suite Results

Ecosystem	Project	Build/Install	Tests	Status
Bun	elysia	✅	1/1 passed	✅ PASS
Bun	hono	✅	1/1 passed	✅ PASS
C++	fmt	✅	N/A	✅ PASS
C++	json	✅	N/A	✅ PASS
Deno	oak	N/A	1/1 passed	✅ PASS
Deno	std	N/A	1/1 passed	✅ PASS
.NET	hello-world	✅	N/A	✅ PASS
.NET	json-parse	✅	N/A	✅ PASS
Go	color	✅	ok	✅ PASS
Go	env	✅	ok	✅ PASS
Go	uuid	✅	ok	✅ PASS
Java	gson	✅	1/1 passed	✅ PASS
Java	caffeine	✅	1/1 passed	✅ PASS
Node.js	clsx	✅	passed	✅ PASS
Node.js	execa	✅	passed	✅ PASS
Node.js	p-limit	✅	passed	✅ PASS
Rust	fd	✅	1/1 passed	✅ PASS
Rust	zoxide	✅	1/1 passed	✅ PASS

Overall: 8/8 ecosystems passed — ✅ PASS

Generated by Build Test Suite for issue #5068 · ◷

Copilot AI review requested due to automatic review settings June 15, 2026 22:37

Copilot started reviewing on behalf of lpcox June 15, 2026 22:37 View session

Copilot AI reviewed Jun 15, 2026

View reviewed changes

Comment thread .github/workflows/ci-gate.yml

with:

script: |

const copilotReviewers = new Set(['copilot', 'copilot[bot]', 'Copilot']);

const copilotReviewers = new Set(['copilot', 'copilot[bot]', 'Copilot', 'copilot-pull-request-reviewer']);

Copilot started work on behalf of lpcox June 15, 2026 22:40 View session

test: update ci-gate reviewer allowlist expectation

6aa0db4

Copilot finished work on behalf of lpcox June 15, 2026 22:42

lpcox added the ready-for-aw label Jun 15, 2026

lpcox temporarily deployed to aoai-model June 15, 2026 22:48 — with GitHub Actions Inactive

github-actions Bot added the smoke-copilot-pat label Jun 15, 2026

github-actions Bot added the smoke-copilot label Jun 15, 2026

lpcox temporarily deployed to aoai-model June 15, 2026 22:52 — with GitHub Actions Inactive

github-actions Bot added the smoke-copilot-byok label Jun 15, 2026

github-actions Bot added the smoke-copilot-byok-aoai-entra label Jun 15, 2026

lpcox temporarily deployed to aoai-model June 15, 2026 22:52 — with GitHub Actions Inactive

github-actions Bot added the smoke-copilot-byok-aoai-apikey label Jun 15, 2026

manamansor reviewed Jun 15, 2026

View reviewed changes

github-actions Bot added the build-test label Jun 15, 2026

github-actions Bot mentioned this pull request Jun 15, 2026

[aw] Contribution Check is missing required data #5071

Closed

lpcox merged commit e2b66b4 into main Jun 15, 2026
83 of 86 checks passed

lpcox deleted the fix/ci-gate-reviewer-login branch June 15, 2026 23:03

github-actions Bot mentioned this pull request Jun 16, 2026

fix: broaden GHES detection for Copilot auth prefix #5076

Merged

Uh oh!

Conversation

lpcox commented Jun 15, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Copilot's findings

Uh oh!

lpcox commented Jun 15, 2026

Uh oh!

Copilot AI commented Jun 15, 2026

Uh oh!

github-actions Bot commented Jun 15, 2026

✅ Coverage Check Passed

Overall Coverage

Uh oh!

github-actions Bot commented Jun 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jun 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jun 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jun 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jun 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jun 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jun 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jun 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jun 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jun 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jun 15, 2026

Uh oh!

github-actions Bot commented Jun 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jun 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jun 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jun 15, 2026

🔥 Smoke Test Results — Auth mode: PAT (COPILOT_GITHUB_TOKEN)

Uh oh!

github-actions Bot commented Jun 15, 2026

🔥 Smoke Test Results — PASS

Uh oh!

github-actions Bot commented Jun 15, 2026

Uh oh!

github-actions Bot commented Jun 15, 2026

Uh oh!

github-actions Bot commented Jun 15, 2026

📡 OTel Tracing Smoke Test Results

Uh oh!

github-actions Bot commented Jun 15, 2026

Chroot Version Comparison Results

Uh oh!

github-actions Bot commented Jun 15, 2026

Uh oh!

manamansor left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Jun 15, 2026

github-actions Bot commented Jun 15, 2026 •

edited

Loading

github-actions Bot commented Jun 15, 2026 •

edited

Loading

github-actions Bot commented Jun 15, 2026 •

edited

Loading

github-actions Bot commented Jun 15, 2026 •

edited

Loading

github-actions Bot commented Jun 15, 2026 •

edited

Loading

github-actions Bot commented Jun 15, 2026 •

edited

Loading

github-actions Bot commented Jun 15, 2026 •

edited

Loading

github-actions Bot commented Jun 15, 2026 •

edited

Loading

github-actions Bot commented Jun 15, 2026 •

edited

Loading

github-actions Bot commented Jun 15, 2026 •

edited

Loading

github-actions Bot commented Jun 15, 2026 •

edited

Loading

github-actions Bot commented Jun 15, 2026 •

edited

Loading

github-actions Bot commented Jun 15, 2026 •

edited

Loading