Skip to content

fix(contribution-check): switch to gpt-5.4-mini and add cancel-in-progress concurrency#5163

Merged
lpcox merged 3 commits into
mainfrom
copilot/copilotallowed-and-disallowed-models-again
Jun 17, 2026
Merged

fix(contribution-check): switch to gpt-5.4-mini and add cancel-in-progress concurrency#5163
lpcox merged 3 commits into
mainfrom
copilot/copilotallowed-and-disallowed-models-again

Conversation

Copilot AI commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

The contribution-check workflow hit HTTP 429 rate limits repeatedly on PR #5095 (11 consecutive failures) due to two compounding issues: claude-haiku-4.5 via the Copilot API gateway has tighter per-model rate limits than native Copilot models, and without cancel-in-progress: true each rapid push queued a new run rather than superseding the previous one.

Changes

  • contribution-check.md
    • model: claude-haiku-4.5model: gpt-5.4-mini — native Copilot model, avoids the Claude-via-Copilot rate limit ceiling
    • Added explicit concurrency block scoped per PR with cancel-in-progress: true — rapid pushes cancel stale queued runs instead of stacking them
concurrency:
  group: "contribution-check-${{ github.event.pull_request.number || github.ref }}"
  cancel-in-progress: true
engine:
  id: copilot
  model: gpt-5.4-mini
  • contribution-check.lock.yml — recompiled with gh aw compile contribution-check (v0.79.8)

…ress concurrency

- Replace claude-haiku-4.5 with gpt-5.4-mini to avoid Copilot/Claude API rate limits (HTTP 429)
- Add explicit concurrency group scoped per PR with cancel-in-progress: true so
  rapid pushes to the same PR cancel the queued run instead of piling up
- Recompile contribution-check.lock.yml (v0.79.8)

Closes #5097
Copilot AI changed the title [WIP] Retry workflow for contribution check failure fix(contribution-check): switch to gpt-5.4-mini and add cancel-in-progress concurrency Jun 17, 2026
Copilot finished work on behalf of lpcox June 17, 2026 15:02
Copilot AI requested a review from lpcox June 17, 2026 15:02
@lpcox lpcox marked this pull request as ready for review June 17, 2026 15:34
Copilot AI review requested due to automatic review settings June 17, 2026 15:34

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the contribution-check agentic workflow to reduce Copilot-side rate limiting and avoid stacked runs by switching to a native Copilot model and enabling per-PR concurrency cancellation.

Changes:

  • Switch engine.model from claude-haiku-4.5 to gpt-5.4-mini in the source workflow.
  • Add a concurrency group with cancel-in-progress: true to supersede stale runs on rapid pushes.
  • Regenerate contribution-check.lock.yml with gh aw compile v0.79.8 to reflect the source workflow updates.
Show a summary per file
File Description
.github/workflows/contribution-check.md Adds PR-scoped concurrency cancellation and updates the Copilot model used by the workflow.
.github/workflows/contribution-check.lock.yml Recompiled locked workflow reflecting the new model + concurrency (and updated gh-aw tooling output).

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 2/2 changed files
  • Comments generated: 5

Comment on lines 18 to +20
engine:
id: copilot
model: claude-haiku-4.5
model: gpt-5.4-mini
Comment on lines 107 to 110
- name: Setup Scripts
id: setup
uses: github/gh-aw-actions/setup@5c2fe865bb4dc46e1450f6ee0d0541d759aea73a # v0.79.6
uses: github/gh-aw-actions/setup@v0.79.8
with:
Comment on lines 438 to 441
- name: Setup Scripts
id: setup
uses: github/gh-aw-actions/setup@5c2fe865bb4dc46e1450f6ee0d0541d759aea73a # v0.79.6
uses: github/gh-aw-actions/setup@v0.79.8
with:
Comment on lines 1060 to 1063
- name: Setup Scripts
id: setup
uses: github/gh-aw-actions/setup@5c2fe865bb4dc46e1450f6ee0d0541d759aea73a # v0.79.6
uses: github/gh-aw-actions/setup@v0.79.8
with:
Comment on lines 1268 to 1271
- name: Setup Scripts
id: setup
uses: github/gh-aw-actions/setup@5c2fe865bb4dc46e1450f6ee0d0541d759aea73a # v0.79.6
uses: github/gh-aw-actions/setup@v0.79.8
with:
@lpcox

lpcox commented Jun 17, 2026

Copy link
Copy Markdown
Collaborator

@copilot address review feedback

@github-actions

github-actions Bot commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

✅ Copilot review passed with no inline comments.

@copilot Add the ready-for-aw label to this PR to trigger agentic CI smoke tests.

Copilot AI commented Jun 17, 2026

Copy link
Copy Markdown
Contributor Author

@copilot address review feedback

Done in commit fix(contribution-check): pin setup SHA and update model test:

  • Updated scripts/ci/contribution-check-workflow.test.ts to assert model: gpt-5.4-mini (was claude-haiku-4.5)
  • Pinned all 4 github/gh-aw-actions/setup references in contribution-check.lock.yml from @v0.79.8 to @c0338fef4749d08c21f8f975fb0e37efa17dda47 # v0.79.8, including the manifest JSON sha field and the comment header line

@github-actions

Copy link
Copy Markdown
Contributor

✅ Coverage Check Passed

Overall Coverage

Metric Base PR Delta
Lines 97.30% 97.61% 📈 +0.31%
Statements 97.16% 97.53% 📈 +0.37%
Functions 98.84% 98.84% ➡️ +0.00%
Branches 91.93% 92.96% 📈 +1.03%
📁 Per-file Coverage Changes (4 files)
File Lines (Before → After) Statements (Before → After)
src/workdir-setup.ts 92.7% → 94.5% (+1.82%) 92.7% → 94.5% (+1.82%)
src/logs/audit-enricher.ts 89.4% → 95.7% (+6.38%) 83.6% → 95.1% (+11.48%)
src/services/agent-volumes/docker-host-staging.ts 87.2% → 95.7% (+8.51%) 87.8% → 95.9% (+8.16%)
src/commands/validators/log-and-limits.ts 90.3% → 100.0% (+9.68%) 90.3% → 100.0% (+9.68%)

Coverage comparison generated by scripts/ci/compare-coverage.ts

@github-actions

github-actions Bot commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Contribution Check completed successfully!

@github-actions

github-actions Bot commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

🔑 Smoke Copilot PAT PAT auth validated. All systems operational. ✅

@github-actions

github-actions Bot commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

📡 Smoke OTel Tracing completed. All tracing scenarios validated. ✅

@github-actions

github-actions Bot commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Smoke Copilot BYOK AOAI (Entra) completed. Copilot AOAI BYOK (Entra) mode operational. 🔓

@github-actions

github-actions Bot commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Smoke Copilot BYOK AOAI (api-key) completed. Copilot AOAI BYOK (api-key) mode operational. 🔓

@github-actions

Copy link
Copy Markdown
Contributor

🚀 Security Guard has started processing this pull request

@github-actions

github-actions Bot commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

📰 VERDICT: Smoke Copilot has concluded. All systems operational. This is a developing story. 🎤

@github-actions

github-actions Bot commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Smoke Copilot BYOK completed. Copilot BYOK mode operational. 🔓

@github-actions

github-actions Bot commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

✨ The prophecy is fulfilled... Smoke Codex has completed its mystical journey. The stars align. 🌟

@github-actions

github-actions Bot commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Smoke Claude failed

@github-actions

github-actions Bot commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

🔌 Smoke Services — All services reachable! ✅

@github-actions

github-actions Bot commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Build Test Suite completed successfully!

@github-actions

github-actions Bot commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Chroot tests passed! Smoke Chroot - All security and functionality tests succeeded.

@github-actions

github-actions Bot commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Smoke Gemini completed. All facets verified. 💎

@github-actions

Copy link
Copy Markdown
Contributor

🔬 Smoke Test: Copilot PAT Auth — PASS

Test Result
GitHub MCP connectivity
GitHub.com HTTP ✅ 200
File write/read

Overall: PASS | Auth mode: PAT (COPILOT_GITHUB_TOKEN)

cc @lpcox @Copilot

🔑 PAT report filed by Smoke Copilot PAT

@github-actions

Copy link
Copy Markdown
Contributor

Smoke Test: Copilot BYOK ✅

Mode: Direct BYOK (COPILOT_PROVIDER_API_KEY) via api-proxy → api.githubcopilot.com

Test Results:

Status: PASS

@lpcox

🔑 BYOK report filed by Smoke Copilot BYOK

@github-actions

Copy link
Copy Markdown
Contributor

@lpcox

  • GitHub MCP testing: ✅
  • GitHub.com connectivity: ✅
  • File write/read: ✅
  • BYOK inference: ✅

Running in direct BYOK mode (AWF_AUTH_TYPE=github-oidc + AWF_AUTH_AZURE_* + COPILOT_PROVIDER_BASE_URL) via api-proxy → Azure OpenAI (Foundry, o4-mini-aw) authenticated via Microsoft Entra

Overall status: PASS

🪪 BYOK (AOAI Entra) report filed by Smoke Copilot BYOK AOAI (Entra)

@github-actions

Copy link
Copy Markdown
Contributor
  • fix(contribution-check): switch to gpt-5.4-mini and add cancel-in-progress concurrency
  • Reduce Pelis Advisor AI credit burn with fixed low-cost model + turn cap
  • fix(ci-cd-gaps-assessment): resolve AI credits rate limit with DataOps refactor
  • ✅ GitHub PR queries
  • ✅ File write/readback
  • ✅ Playwright title check
  • ✅ Build (npm ci && npm run build)
  • PASS

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

  • registry.npmjs.org

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "registry.npmjs.org"

See Network Configuration for more information.

🔮 The oracle has spoken through Smoke Codex

@github-actions

Copy link
Copy Markdown
Contributor

@Copilot @lpcox

Running in direct BYOK mode (COPILOT_PROVIDER_API_KEY + COPILOT_PROVIDER_BASE_URL) via api-proxy → Azure OpenAI (Foundry, o4-mini-aw)

  • MCP connectivity: ✅
  • GitHub.com HTTP: ✅
  • File I/O: ✅
  • BYOK inference: ✅

Overall: PASS

🔑 BYOK (AOAI api-key) report filed by Smoke Copilot BYOK AOAI (api-key)

@github-actions

Copy link
Copy Markdown
Contributor

Chroot Version Comparison Results

Runtime Host Version Chroot Version Match?
Python Python 3.12.13 Python 3.12.3 ❌ NO
Node.js v24.16.0 v22.22.3 ❌ NO
Go go1.22.12 go1.22.12 ✅ YES

Overall: ❌ FAILED — Python and Node.js versions differ between host and chroot environments.

Tested by Smoke Chroot

@github-actions

Copy link
Copy Markdown
Contributor

📡 Smoke Test: API Proxy OpenTelemetry Tracing

Scenario Status Result
1. Module Loading otel.js loaded; isEnabled() = true; exports 13 functions (startRequestSpan, setTokenAttributes, setBudgetAttributes, endSpan, endSpanError, shutdown, isEnabled, + internal helpers)
2. Test Suite 59 tests passed, 0 failed across otel.test.js + otel-fanout.test.js
3. Env Var Forwarding ⚠️ Step script checks wrong file (api-proxy-service.ts); forwarding is confirmed in api-proxy-service-config.tsGH_AW_OTLP_ENDPOINTS, OTEL_EXPORTER_OTLP_ENDPOINT, GITHUB_AW_OTEL_TRACE_ID, GITHUB_AW_OTEL_PARENT_SPAN_ID, OTEL_SERVICE_NAME all forwarded
4. Token Tracker Integration onUsage + onSpanEnd callbacks confirmed in token-tracker-http.js
5. OTEL Diagnostics No span file (expected — no live LLM call in this run; graceful degradation working)

Overall: All scenarios pass. Scenario 3 shows a false negative — the validation script grep targets the wrong source file; the actual env var forwarding is implemented and confirmed in api-proxy-service-config.ts.

📡 OTel tracing validated by Smoke OTel Tracing

@github-actions

Copy link
Copy Markdown
Contributor

🔍 Smoke Test Results

PR: fix(contribution-check): switch to gpt-5.4-mini and add cancel-in-progress concurrency
Author: @Copilot | Assignees: @lpcox @Copilot

Test Status
GitHub MCP connectivity
GitHub.com HTTP ✅ 200
File write/read

Overall: PASS

📰 BREAKING: Report filed by Smoke Copilot

@github-actions

Copy link
Copy Markdown
Contributor

Smoke Test Results

Check Result
Redis PING ❌ connection timeout
PostgreSQL pg_isready ❌ no response
PostgreSQL SELECT 1 ❌ not reachable

host.docker.internal resolves to 172.17.0.1 but services are not accepting connections on ports 6379 or 5432.

Overall: FAIL

🔌 Service connectivity validated by Smoke Services

@github-actions

Copy link
Copy Markdown
Contributor

Smoke Test: Gemini Engine Validation

Overall Status: PASS

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

  • localhost

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "localhost"

See Network Configuration for more information.

💎 Faceted by Smoke Gemini

@github-actions

Copy link
Copy Markdown
Contributor

🏗️ Build Test Suite Results

Ecosystem Project Build/Install Tests Status
Bun elysia 1/1 passed ✅ PASS
Bun hono 1/1 passed ✅ PASS
C++ fmt N/A ✅ PASS
C++ json N/A ✅ PASS
Deno oak N/A 1/1 passed ✅ PASS
Deno std N/A 1/1 passed ✅ PASS
.NET hello-world N/A ✅ PASS
.NET json-parse N/A ✅ PASS
Go color passed ✅ PASS
Go env passed ✅ PASS
Go uuid passed ✅ PASS
Java gson 1/1 passed ✅ PASS
Java caffeine 1/1 passed ✅ PASS
Node.js clsx All passed ✅ PASS
Node.js execa All passed ✅ PASS
Node.js p-limit All passed ✅ PASS
Rust fd 1/1 passed ✅ PASS
Rust zoxide 1/1 passed ✅ PASS

Overall: 8/8 ecosystems passed — ✅ PASS

Environment notes
  • AWF Squid proxy active at 172.30.0.10:3128; all traffic routed through it
  • Java: Maven local repo redirected to /tmp/gh-aw/agent/m2repo (runner's ~/.m2 was root-owned)
  • Bun 1.3.14 installed; Deno 2.8.3 installed
  • Go, Node.js v22, .NET 10.0, Rust 1.96, Java 21, CMake 3.31 all pre-installed

Generated by Build Test Suite for issue #5163 ·

@lpcox lpcox merged commit 7fee543 into main Jun 17, 2026
83 of 87 checks passed
@lpcox lpcox deleted the copilot/copilotallowed-and-disallowed-models-again branch June 17, 2026 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants