[Test Coverage] host-iptables-chain.ts - #6217
Conversation
…BridgeMock fallback - Add tests for line 13 (throw error re-throw) in host-iptables-chain.ts when iptables --version fails with non-ENOENT errors (segfault, permission denied, ETIMEDOUT) — brings host-iptables-chain.ts to 100% coverage - Exercise setupDockerBridgeMock fallback chain (lines 120, 122) in host-iptables-test-setup.ts with and without a prior mock implementation — improves test-setup branch coverage from 93.33% to 96.66% Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
| describe('host-iptables-chain – non-ENOENT version error re-throw (line 13)', () => { | ||
| setupHostIptablesTestSuite(iptablesSharedTestHelpers.resetIpv6State); | ||
|
|
||
| it('re-throws the original error when iptables --version fails with a non-ENOENT error', async () => { |
|
@copilot address review feedback |
Confirmed: |
|
✅ Copilot review passed with no inline comments. @github-actions[bot] Add the |
|
@copilot merge main |
…tables-chain-rethrow-5822c95abac70fc2
|
📡 Smoke OTel Tracing completed. All tracing scenarios validated. ✅ |
|
✨ The prophecy is fulfilled... Smoke Codex has completed its mystical journey. The stars align. 🌟 |
|
❌ Smoke Copilot BYOK AOAI (Entra) reports failed. AOAI BYOK (Entra) mode investigation needed... |
|
🔌 Smoke Services — All services reachable! ✅ |
|
✅ Smoke Claude passed |
|
🔑 Smoke Copilot PAT PAT auth validated. All systems operational. ✅ |
|
❌ Smoke Copilot BYOK AOAI (api-key) reports failed. AOAI BYOK (api-key) mode investigation needed... |
|
✅ Build Test Suite completed successfully! |
|
Chroot tests passed! Smoke Chroot - All security and functionality tests succeeded. |
|
🐳🔮 Smoke Docker Sbx Codex completed. Docker sbx + Codex smoke test passed. ✅ |
|
📡 Smoke OTel Tracing completed. All tracing scenarios validated. ✅ |
|
🦎🏗️ Smoke gVisor Build Test completed. gVisor build test passed. ✅ |
|
✅ Smoke Copilot BYOK completed. Copilot BYOK mode operational. 🔓 |
|
🐳🏗️ Smoke Docker Sbx Build Test completed. Docker sbx build test passed. ✅ |
|
🐳🟣 Smoke Docker Sbx Claude completed. Docker sbx + Claude smoke test passed. ✅ |
|
Thanks for adding focused coverage for the previously uncovered paths. One contribution-guideline item remains: the PR description should reference any related issue, as required by CONTRIBUTING.md under Pull Request Process → Pull request requirements (lines 109–114). If there is no related issue, please state that explicitly in the description. Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
network:
allowed:
- defaults
- "awmgmcpg"See Network Configuration for more information.
|
This comment has been minimized.
This comment has been minimized.
🦎 gVisor Smoke Test Results
Overall: PASS (gVisor unconfirmed is expected until runtime plumbing is added) /cc Warning Firewall blocked 2 domainsThe following domains were blocked by the firewall during workflow execution:
network:
allowed:
- defaults
- "example.com"
- "host.docker.internal"See Network Configuration for more information.
|
Smoke Test: Copilot PAT Auth
Overall: FAIL — workflow Auth mode: PAT (COPILOT_GITHUB_TOKEN) | Author: Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
network:
allowed:
- defaults
- "awmgmcpg"See Network Configuration for more information.
|
Smoke Test: Services Connectivity
Overall: FAIL — Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
network:
allowed:
- defaults
- "awmgmcpg"See Network Configuration for more information.
|
Smoke Test: Claude Engine Validation
Overall result: PASS Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
network:
allowed:
- defaults
- "awmgmcpg"See Network Configuration for more information.
|
🔬 Smoke Test Results
Overall: PASS | PR #6217 | Author: Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
network:
allowed:
- defaults
- "awmgmcpg"See Network Configuration for more information.
|
🦎🏗️ gVisor Build Test Results
Overall: FAIL Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
network:
allowed:
- defaults
- "host.docker.internal"See Network Configuration for more information.
|
Smoke Test: Copilot BYOK (Direct)Running in direct BYOK mode (
Overall: PASS · cc Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
network:
allowed:
- defaults
- "awmgmcpg"See Network Configuration for more information.
|
Smoke Test: API Proxy OpenTelemetry Tracing
All 5 scenarios passed. OTEL tracing integration is working correctly. Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
network:
allowed:
- defaults
- "awmgmcpg"See Network Configuration for more information.
|
Smoke Test: Gemini Engine Validation
Overall status: FAIL Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
network:
allowed:
- defaults
- "localhost"See Network Configuration for more information.
|
🔍 Smoke Test Results
Overall: PARTIAL — MCP works; pre-step data unavailable for full validation.
|
🏗️ Build Test Suite Results
Overall: 8/8 ecosystems passed — ✅ PASS Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
network:
allowed:
- defaults
- "awmgmcpg"See Network Configuration for more information.
|
|
Merged PRs:
Checks:
Overall: FAIL Warning Firewall blocked 2 domainsThe following domains were blocked by the firewall during workflow execution:
network:
allowed:
- defaults
- "awmgmcpg"
- "registry.npmjs.org"See Network Configuration for more information.
|
|
🦎🟣 Smoke gVisor Claude completed. gVisor + Claude smoke test passed. ✅ |
|
🐳🔮 Docker sbx + Codex
|
🐳🏗️ Docker Sbx Build Test Results
Overall: FAIL
|
Chroot Version Comparison
Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
network:
allowed:
- defaults
- "awmgmcpg"See Network Configuration for more information.
|
🐳🟣 Docker sbx + Claude
Overall status: FAIL
|
🦎🟣 gVisor + Claude Smoke Test
Overall: PASS Warning Firewall blocked 2 domainsThe following domains were blocked by the firewall during workflow execution:
network:
allowed:
- defaults
- "example.com"
- "host.docker.internal"See Network Configuration for more information.
|
Summary
Adds 6 new unit tests covering two previously-uncovered code paths:
host-iptables-chain.ts→ 100% coverageLine 13 (
throw error) is the re-throw path incheckPermissionsAndSetupChainwheniptables --versionfails with a non-ENOENT error. All prior tests only exercised the ENOENT path. Three new tests cover:host-iptables-test-setup.ts→ 96.66% branch coverage (up from 93.33%)The
setupDockerBridgeMockhelper (lines 112, 120) was never called in isolation. Four new tests exercise:Test results
All 6 new tests pass. No existing tests modified.
Files changed
src/host-iptables-chain-rethrow.test.ts(new)Warning
Firewall blocked 1 domain
The following domain was blocked by the firewall during workflow execution:
awmgmcpgSee Network Configuration for more information.