[log] Add debug logging to health endpoint handler#323
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enhanced
internal/server/health.gowith debug logging to improve troubleshooting and visibility of health check operations.Changes
Logger Declaration
"github.com/githubnext/gh-aw-mcpg/internal/logger"var logHealth = logger.New("server:health")Debug Logging Added (5 calls)
Logger Guidelines Compliance
✅ Naming Convention: Follows
pkg:filenamepattern (server:health)✅ No Side Effects: All log arguments are simple variables, no function calls
✅ Meaningful Messages: Each log provides context useful for debugging
✅ Proper Formatting: Uses
Printfwith format strings for structured output✅ Single File Focus: Only modified
health.gofor focused, reviewable changesDebug Output Example
When
DEBUG=server:healthorDEBUG=*is set:Testing Notes
The enhanced logging will help diagnose:
Note: This PR focuses on a single file for thorough, reviewable changes following the logging enhancement guidelines.