refactor: extract ParseCollaboratorPermissionArgs to eliminate cross-package duplication

[Copilot]

The get_collaborator_permission arg parsing logic (owner/repo/username extraction + validation) was duplicated verbatim in internal/server/unified.go and internal/proxy/proxy.go, creating a drift risk between two separate HTTP implementations.

Changes

• internal/mcp/collaborator_permission.go — new ParseCollaboratorPermissionArgs(argsMap map[string]interface{}) (owner, repo, username string, err error) helper; returns partial values on error so callers can include them in log messages
• internal/mcp/collaborator_permission_test.go — TestParseCollaboratorPermissionArgs covering happy path, each missing field, and partial-value-on-error behavior
• internal/server/unified.go — callCollaboratorPermission replaces 8-line inline extraction with the shared helper
• internal/proxy/proxy.go — restBackendCaller.CallTool uses the helper via function-scoped collabOwner/collabRepo/collabUsername vars, also eliminating the redundant post-switch argsMap re-read

// Before (duplicated in both files):
owner, _ := argsMap["owner"].(string)
repo, _ := argsMap["repo"].(string)
username, _ := argsMap["username"].(string)
if owner == "" || repo == "" || username == "" {
    return nil, fmt.Errorf("get_collaborator_permission: missing owner/repo/username")
}

// After:
owner, repo, username, err := mcp.ParseCollaboratorPermissionArgs(argsMap)
if err != nil {
    logUnified.Printf("get_collaborator_permission: missing required args (owner=%q repo=%q username=%q)", owner, repo, username)
    return nil, err
}

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

• example.com
  • Triggering command: /tmp/go-build2075080314/b509/launcher.test /tmp/go-build2075080314/b509/launcher.test -test.testlogfile=/tmp/go-build2075080314/b509/testlog.txt -test.paniconexit0 -test.timeout=10m0s -test.v=true p/go-build main x_amd64/compile (dns block)
  • Triggering command: /tmp/go-build1743922486/b513/launcher.test /tmp/go-build1743922486/b513/launcher.test -test.testlogfile=/tmp/go-build1743922486/b513/testlog.txt -test.paniconexit0 -test.timeout=10m0s -o 5080314/b497/difc.test -trimpath x_amd64/vet -p google.golang.or-atomic -lang=go1.24 x_amd64/vet -o ry=1 -trimpath x_amd64/vet -p google.golang.or/usr/bin/runc -lang=go1.24 x_amd64/vet (dns block)
• invalid-host-that-does-not-exist-12345.com
  • Triggering command: /tmp/go-build2075080314/b491/config.test /tmp/go-build2075080314/b491/config.test -test.testlogfile=/tmp/go-build2075080314/b491/testlog.txt -test.paniconexit0 -test.timeout=10m0s -test.v=true 64/src/runtime/c-p o x_amd64/asm (dns block)
  • Triggering command: /tmp/go-build1743922486/b495/config.test /tmp/go-build1743922486/b495/config.test -test.testlogfile=/tmp/go-build1743922486/b495/testlog.txt -test.paniconexit0 -test.timeout=10m0s -o zU9f4ahsV -trimpath ache/go/1.25.9/x64/pkg/tool/linux_amd64/vet -p go.opentelemetry/tmp/go-build1387771901/b265/vet.cfg -lang=go1.25 ortcfg -I aw-mcpg/internal/launcher/connection_pool.go aw-mcpg/internal/launcher/health_monitor.go (dns block)
• nonexistent.local
  • Triggering command: /tmp/go-build2075080314/b509/launcher.test /tmp/go-build2075080314/b509/launcher.test -test.testlogfile=/tmp/go-build2075080314/b509/testlog.txt -test.paniconexit0 -test.timeout=10m0s -test.v=true p/go-build main x_amd64/compile (dns block)
  • Triggering command: /tmp/go-build1743922486/b513/launcher.test /tmp/go-build1743922486/b513/launcher.test -test.testlogfile=/tmp/go-build1743922486/b513/testlog.txt -test.paniconexit0 -test.timeout=10m0s -o 5080314/b497/difc.test -trimpath x_amd64/vet -p google.golang.or-atomic -lang=go1.24 x_amd64/vet -o ry=1 -trimpath x_amd64/vet -p google.golang.or/usr/bin/runc -lang=go1.24 x_amd64/vet (dns block)
• slow.example.com
  • Triggering command: /tmp/go-build2075080314/b509/launcher.test /tmp/go-build2075080314/b509/launcher.test -test.testlogfile=/tmp/go-build2075080314/b509/testlog.txt -test.paniconexit0 -test.timeout=10m0s -test.v=true p/go-build main x_amd64/compile (dns block)
  • Triggering command: /tmp/go-build1743922486/b513/launcher.test /tmp/go-build1743922486/b513/launcher.test -test.testlogfile=/tmp/go-build1743922486/b513/testlog.txt -test.paniconexit0 -test.timeout=10m0s -o 5080314/b497/difc.test -trimpath x_amd64/vet -p google.golang.or-atomic -lang=go1.24 x_amd64/vet -o ry=1 -trimpath x_amd64/vet -p google.golang.or/usr/bin/runc -lang=go1.24 x_amd64/vet (dns block)
• this-host-does-not-exist-12345.com
  • Triggering command: /tmp/go-build2075080314/b518/mcp.test /tmp/go-build2075080314/b518/mcp.test -test.testlogfile=/tmp/go-build2075080314/b518/testlog.txt -test.paniconexit0 -test.timeout=10m0s -test.v=true rnal/pragma/prag-errorsas ache/go/1.25.9/x-ifaceassert 64/pkg/tool/linu-nilfunc -p syscall -lang=go1.25 64/pkg/tool/linu-buildtags go_.�� dns/dns_resolver-errorsas .cfg x_amd64/compile -p crypto/ed25519 -lang=go1.25 x_amd64/compile (dns block)
  • Triggering command: /tmp/go-build1743922486/b522/mcp.test /tmp/go-build1743922486/b522/mcp.test -test.testlogfile=/tmp/go-build1743922486/b522/testlog.txt -test.paniconexit0 -test.timeout=10m0s -o /tmp/go-build2075080314/b439/_pkg_.a -trimpath x_amd64/vet -p google.golang.or--version -lang=go1.25 x_amd64/vet -ato�� submodules | head -n 10 din}} x_amd64/vet -errorsas -ifaceassert -nilfunc x_amd64/vet (dns block)
  • Triggering command: /tmp/go-build3917726863/b253/mcp.test /tmp/go-build3917726863/b253/mcp.test -test.testlogfile=/tmp/go-build3917726863/b253/testlog.txt -test.paniconexit0 -test.timeout=10m0s bug/�� bug/deps/github_guard-57d41235e07a5585.3r7b32ab9hw1mmy6a1aekmmsh.1qicuz7.rcgu.o bug/deps/github_guard-57d41235e07a5585.485oswk5h4p2kq4dabhq5b2ke.1qicuz7.rcgu.o -guard/target/de--diagnostic-width=120 by/5614fb8de41e5mktemp -trimpath lib/rustlib/x86_codeql.XXXXXXXX lib/rustlib/x86_-C lib/�� -guard/target/debug/deps/rustcHdHtL6/symbols.o -guard/target/debug/deps/github_guard-57d41235e07a5585.0r6f2y9pmz8tylr32cgwnziux.1qicuz7.rcgu.o -guard/target/debug/deps/github_guard-57d41235e07a5585.0y8i0suihruczucboywd9kbz6.1qicuz7.rcgu.o -guard/target/de/bin/sh -guard/target/de-c -guard/target/deecho " release - Trigger the release workflow (usage: make release patch|minor|major)" -guard/target/debug/deps/github_guard-57d41235e07a5585.1yg4dgf4ofc88gtczrpthgg1u.1qicuz7.rcgu.o (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

• Configure Actions setup steps to set up my environment, which run before the firewall is enabled
• Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

[Copilot]

Pull request overview

Refactors duplicated get_collaborator_permission argument parsing (owner/repo/username extraction + validation) into a shared helper in internal/mcp, keeping the unified server and proxy REST implementations in sync.

Changes:

• Added mcp.ParseCollaboratorPermissionArgs to centralize parsing/validation and return partial values on error for better logging.
• Updated unified server and proxy call paths to use the shared helper (and avoid re-reading args in the proxy).
• Added unit tests for the new parsing helper.

Show a summary per file

File	Description
internal/mcp/collaborator_permission.go	Adds shared ParseCollaboratorPermissionArgs helper used by both server and proxy.
internal/mcp/collaborator_permission_test.go	Adds tests covering success, missing-field errors, and partial-return behavior.
internal/server/unified.go	Replaces inline parsing in callCollaboratorPermission with the shared helper.
internal/proxy/proxy.go	Uses the shared helper in restBackendCaller.CallTool and reuses parsed values for post-call logging/wrapping.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

• Files reviewed: 4/4 changed files
• Comments generated: 1