docs(logger): document intentional Log-Level Quad-Function Pattern as stable

[Copilot]

Three logger files each repeat a near-identical 4-function block (LogInfo/Warn/Error/Debug variants) that wraps closures built by makeLevelLogger/makeServerLevelLogger. The pattern is correct and idiomatic Go — the duplication is intentional — but nothing in the code communicated that decision to future contributors.

Changes

• common.go — Expanded the "Log-Level Quad-Function Pattern" doc block to:

  • State explicitly that the four log levels are stable and not expected to grow
  • Explain why code generation was rejected (passive wrappers, negligible risk, API discoverability)
  • Add numbered instructions covering all five touch-points if a level is ever added (including the test in log_level_wrappers_test.go)

• file_logger.go / markdown_logger.go / server_file_logger.go — Added a 4-line cross-reference comment on each var block directing contributors to common.go for rationale and update steps

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

• example.com
  • Triggering command: /tmp/go-build3939558618/b513/launcher.test /tmp/go-build3939558618/b513/launcher.test -test.testlogfile=/tmp/go-build3939558618/b513/testlog.txt -test.paniconexit0 -test.timeout=10m0s /tmp/go-build3939558618/b437/vet.cfg w6WVsrdoR 2085962/b314/ x_amd64/vet /tmp/go-build286/opt/hostedtoolcache/go/1.25.9/x64/pkg/tool/linux_amd64/vet -O2 -fno-stack-prote-bool x_amd64/vet 2085�� olang.org/grpc@v-errorsas olang.org/grpc@v-ifaceassert x_amd64/vet . --gdwarf2 --64 x_amd64/vet (dns block)
• invalid-host-that-does-not-exist-12345.com
  • Triggering command: /tmp/go-build3939558618/b495/config.test /tmp/go-build3939558618/b495/config.test -test.testlogfile=/tmp/go-build3939558618/b495/testlog.txt -test.paniconexit0 -test.timeout=10m0s /tmp/go-build3939558618/b399/vet.cfg g_.a -I x_amd64/vet --gdwarf-5 gr/stdr -o x_amd64/vet -W Qhn-DafK5 cfg x_amd64/vet . --gdwarf2 --64 x_amd64/vet (dns block)
• nonexistent.local
  • Triggering command: /tmp/go-build3939558618/b513/launcher.test /tmp/go-build3939558618/b513/launcher.test -test.testlogfile=/tmp/go-build3939558618/b513/testlog.txt -test.paniconexit0 -test.timeout=10m0s /tmp/go-build3939558618/b437/vet.cfg w6WVsrdoR 2085962/b314/ x_amd64/vet /tmp/go-build286/opt/hostedtoolcache/go/1.25.9/x64/pkg/tool/linux_amd64/vet -O2 -fno-stack-prote-bool x_amd64/vet 2085�� olang.org/grpc@v-errorsas olang.org/grpc@v-ifaceassert x_amd64/vet . --gdwarf2 --64 x_amd64/vet (dns block)
• slow.example.com
  • Triggering command: /tmp/go-build3939558618/b513/launcher.test /tmp/go-build3939558618/b513/launcher.test -test.testlogfile=/tmp/go-build3939558618/b513/testlog.txt -test.paniconexit0 -test.timeout=10m0s /tmp/go-build3939558618/b437/vet.cfg w6WVsrdoR 2085962/b314/ x_amd64/vet /tmp/go-build286/opt/hostedtoolcache/go/1.25.9/x64/pkg/tool/linux_amd64/vet -O2 -fno-stack-prote-bool x_amd64/vet 2085�� olang.org/grpc@v-errorsas olang.org/grpc@v-ifaceassert x_amd64/vet . --gdwarf2 --64 x_amd64/vet (dns block)
• this-host-does-not-exist-12345.com
  • Triggering command: /tmp/go-build3939558618/b522/mcp.test /tmp/go-build3939558618/b522/mcp.test -test.testlogfile=/tmp/go-build3939558618/b522/testlog.txt -test.paniconexit0 -test.timeout=10m0s rtcf�� vel-wrapper 64/src/internal/-ifaceassert x_amd64/vet --gdwarf-5 .io/proto/otlp/c/usr/bin/runc -o x_amd64/vet -W .cfg /tmp/go-build2862085962/b314/ x_amd64/cgo . --gdwarf2 --64 x_amd64/cgo (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

• Configure Actions setup steps to set up my environment, which run before the firewall is enabled
• Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

[Copilot]

Pull request overview

Documents the intentional “Log-Level Quad-Function Pattern” used by the logger package, clarifying that the Info/Warn/Error/Debug wrapper sets are a stable, deliberate API choice and providing explicit maintenance steps if a new level is ever introduced.

Changes:

• Expanded internal/logger/common.go documentation to explain why the 4-level wrapper pattern is intentional/stable and why code generation was rejected.
• Added explicit, numbered “if a new LogLevel is added” update steps, including the existing wrapper-coverage test.
• Added short cross-reference comments above the per-file wrapper var blocks in the three logger implementations to point contributors to common.go.

Show a summary per file

File	Description
internal/logger/common.go	Extends the doc block with rationale, stability expectations, and concrete update instructions (including the wrapper coverage test).
internal/logger/file_logger.go	Adds a cross-reference comment above the level-bound closure var block pointing to the pattern documentation.
internal/logger/markdown_logger.go	Adds the same cross-reference comment above the markdown wrapper var block.
internal/logger/server_file_logger.go	Adds the same cross-reference comment above the server wrapper var block.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

• Files reviewed: 4/4 changed files
• Comments generated: 0