[log] Add debug logging to vcsTimeFromBuildInfo - #9361
Merged
Conversation
Mirror the debug logging pattern already present in vcsCommitFromBuildInfo. This makes both VCS metadata extraction functions consistent and helps troubleshoot version string generation when build info is unavailable or missing expected settings. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds debug logging to vcsTimeFromBuildInfo in internal/version/version.go, aligning its observability with the existing logging already present in vcsCommitFromBuildInfo to help troubleshoot missing VCS build metadata.
Changes:
- Added a debug log when
buildInfoisnilinvcsTimeFromBuildInfo. - Added a debug log when
vcs.timeis found (including the extracted value). - Added a debug log when
vcs.timeis not found in build settings.
Show a summary per file
| File | Description |
|---|---|
| internal/version/version.go | Adds debug logging around vcs.time extraction to improve troubleshooting consistency with vcsCommitFromBuildInfo. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Low
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This was referenced Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds debug logging to
vcsTimeFromBuildInfoininternal/version/version.go, mirroring the existing logging pattern already present invcsCommitFromBuildInfo.Changes
internal/version/version.go: Added 3logVersiondebug calls tovcsTimeFromBuildInfo:vcs.timeis found (with the value)vcs.timeis not found in build settingsWhy
Both VCS metadata extraction functions (
vcsCommitFromBuildInfoandvcsTimeFromBuildInfo) serve the same purpose but only the commit variant had debug logging. This makes them consistent and helps troubleshoot version string generation issues when the gateway fails to embed build metadata.Validation
go test ./internal/version/passedgo vet ./internal/version/passedgo build -o awmg .succeededWarning
Firewall blocked 1 domain
The following domain was blocked by the firewall during workflow execution:
awmgmcpgSee Network Configuration for more information.