refactor(rust-guard): eliminate duplicated author_association lookup and raw field-name literals in backend.rs

[Copilot]

backend.rs had two inline copies of the author_association/authorAssociation dual-alias extraction pattern, despite helpers.rs already owning a helper for exactly this. It also used raw "full_name" and "login" string literals in five production-code sites while the field_names constants module (already imported in the test block of the same file) exists as the single source of truth for those names.

Changes

helpers.rs

• get_author_association: fn → pub(crate) fn (minimal visibility bump to expose within crate)

backend.rs — imports

// before
use super::constants::{MEDIUM_BUFFER_SIZE, SMALL_BUFFER_SIZE};
use super::helpers::is_pr_merged;

// after
use super::constants::{field_names, MEDIUM_BUFFER_SIZE, SMALL_BUFFER_SIZE};
use super::helpers::{get_author_association, is_pr_merged};

backend.rs — deduplicate author_association extraction (2 sites)

// before (repeated verbatim in both get_pull_request_facts_with_callback and get_issue_author_info_with_callback)
let author_association = item
    .get("author_association")
    .or_else(|| item.get("authorAssociation"))
    .and_then(|v| v.as_str())
    .map(String::from);

// after
let author_association = get_author_association(&item).map(String::from);

backend.rs — replace raw field-name literals with constants (5 sites)

• "full_name" → field_names::FULL_NAME (base and head repo in get_pull_request_facts_with_callback)
• "login" → field_names::LOGIN (PR author, issue author, collaborator #[cfg(test)] path)

• Fixes [rust-guard] Rust Guard: Eliminate duplicated author_association lookup in backend.rs #9512

[Copilot]

Pull request overview

Centralizes GitHub response-field extraction in the Rust guard.

Changes:

• Exposes the existing author-association helper within the crate.
• Reuses shared extraction helpers and field-name constants in backend logic.

Show a summary per file

File	Description
helpers.rs	Makes get_author_association crate-visible.
backend.rs	Removes duplicate extraction logic and raw field-name literals.

Review details

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

• Files reviewed: 2/2 changed files
• Comments generated: 0
• Review effort level: Medium