refactor: centralize outlier functions and deduplicate shared scaffolding

[Copilot]

Addresses findings from semantic function clustering analysis: four functions sat in wrong files, and two logger types duplicated the same three-field state struct.

Changes

internal/auth/id.go (new)

• Moves GenerateRandomAgentID out of header.go (which only does header parsing/validation) into a dedicated file
• Moves logAPIKey logger with it; updates namespace test exception list from header.go → id.go
• Removes now-unused fmt and util imports from header.go

internal/logger/fileutil.go — jsonFileSink base struct

• ToolsLogger and ObservedURLDomainsLogger both carried identical logDir string, fileName string, useFallback bool fields
• Consolidates them into an embedded jsonFileSink struct with a writeJSON(data, perm) helper:

// Before — duplicated in both logger types:
type ToolsLogger struct {
    lockable
    logDir      string
    fileName    string
    data        *ToolsData
    useFallback bool
}

// After — shared base:
type ToolsLogger struct {
    lockable
    jsonFileSink        // logDir, fileName, useFallback + writeJSON()
    data *ToolsData
}

internal/util/toolname.go (new) — ParseServerIDFromToolName

• parseServerIDFromToolName was a generic string utility embedded in jqschema.go (jq filtering logic)
• Exported as util.ParseServerIDFromToolName with a dedicated toolname_test.go; jqschema.go and its coverage test updated to call the canonical location

Session ID extraction (no change needed)

• extractSessionIDFromRequest in server/session.go is already a minimal one-line wrapper over auth.ExtractSessionIDFromHeaders — no duplication to fix

• Fixes [refactor] Semantic Function Clustering Analysis — Outliers, Near-Duplicates, and Scattered Helpers #9653

[Copilot]

Pull request overview

Centralizes misplaced helpers and deduplicates JSON-backed logger state.

Changes:

• Moves agent ID generation and tool-name parsing into focused modules.
• Introduces shared jsonFileSink logger scaffolding.
• Updates callers, tests, and logger namespace exceptions.

Show a summary per file

File	Description
internal/auth/id.go	Houses agent ID generation.
internal/auth/header.go	Removes ID generation concerns.
internal/util/toolname.go	Adds canonical server ID parser.
internal/util/toolname_test.go	Tests tool-name parsing.
internal/middleware/jqschema.go	Uses the canonical parser.
internal/middleware/jqschema_coverage_test.go	Updates parser references.
internal/logger/fileutil.go	Adds shared JSON sink state.
internal/logger/tools_logger.go	Embeds the shared sink.
internal/logger/tools_logger_test.go	Updates logger construction.
internal/logger/observed_url_domains_logger.go	Embeds the shared sink.
internal/logger/observed_url_domains_logger_test.go	Updates sink-related tests.
internal/logger/logger_namespace_test.go	Moves the API-key namespace exception.

Review details

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

• Files reviewed: 12/12 changed files
• Comments generated: 2
• Review effort level: Medium

[lpcox]

Done in 3ffc166 — removed the duplicate TestParseServerIDFromToolName block and the now-unused util import. The canonical table in internal/util/toolname_test.go covers these cases and TestAuditObservedURLDomains covers the middleware call site.

[lpcox]

Done in 3ffc166 — moved the ID-generation failure/recovery tests and the errorReader helper into a new internal/auth/id_test.go, and dropped the now-unused crypto/rand and errors imports from header_test.go.