[log] Add debug logging to extractContainerIDFromCgroupFiles - #9661
Merged
Conversation
Add meaningful debug logging to the cgroup file scanning function in internal/sys/container.go to help troubleshoot container detection issues. The new log calls record: - How many cgroup files are being scanned - When a file is unreadable (with path and error) - When a container ID is successfully extracted (with path and ID) - When no container ID is found in a given file - When all files have been exhausted without finding an ID Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds diagnostic logging to improve cgroup-based container ID detection observability.
Changes:
- Logs cgroup scan progress, unreadable files, and unsuccessful extraction.
- Logs the source and ID when extraction succeeds.
Show a summary per file
| File | Description |
|---|---|
internal/sys/container.go |
Adds debug logging around cgroup file scanning. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Medium
This was referenced Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds 5 meaningful debug log calls to
internal/sys/container.goin theextractContainerIDFromCgroupFilesfunction, which previously silently iterated cgroup files with no observability.Changes
File modified:
internal/sys/container.goThe
extractContainerIDFromCgroupFilesfunction now logs:Motivation
Container detection failures are hard to diagnose. Previously, this function silently skipped unreadable files and returned empty without any trace of what was attempted. With
DEBUG=sys:*enabled, operators can now see exactly which cgroup files were probed and why extraction succeeded or failed.Validation
go vet ./internal/sys/✅go test ./internal/sys/✅go build✅Warning
Firewall blocked 1 domain
The following domain was blocked by the firewall during workflow execution:
awmgmcpgSee Network Configuration for more information.