Format config schema error locations as JSON Pointers - #9698
Merged
Conversation
5 tasks
Copilot
AI
changed the title
[WIP] Review Go module santhosh-tekuri/jsonschema/v6
Format config schema error locations as JSON Pointers
Jul 20, 2026
lpcox
marked this pull request as ready for review
July 20, 2026 15:06
Contributor
There was a problem hiding this comment.
Pull request overview
Formats config validation locations as JSON Pointers and adds schema-specific guidance.
Changes:
- Adds leading slashes to validation locations.
- Adds
allOfand conditional guidance. - Expands regression tests.
Show a summary per file
| File | Description |
|---|---|
internal/config/validation_schema.go |
Updates location formatting and error guidance. |
internal/config/validation_schema_error_format_test.go |
Tests pointer formatting and keyword guidance. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 2/2 changed files
- Comments generated: 2
- Review effort level: Medium
Comment on lines
+278
to
280
| if len(ve.InstanceLocation) > 0 { | ||
| location = "/" + strings.Join(ve.InstanceLocation, "/") | ||
| } |
Comment on lines
+509
to
+510
| if keywordPath := ve.ErrorKind.KeywordPath(); len(keywordPath) > 0 { | ||
| addFromKeyword(keywordPath[0]) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The config validator was emitting
jsonschema.ValidationError.InstanceLocationvalues without the leading/, so user-facing paths were not RFC 6901 JSON Pointers. It also fell back to generic guidance for some schema composition/conditional failures instead of surfacing actionable context.JSON Pointer formatting
InstanceLocationvalues as RFC 6901-style pointers.<root>for top-level failures.Richer schema error guidance
allOffailures.if,then, andelse.Focused regression coverage
allOfmessaging and keyword-path fallback behavior.