[test] Remove dead nil guards and unreachable else branch in logger/jsonl_logger.go

[github-actions]

Code Quality Improvement: Dead Code Removal in jsonl_logger.go

What Changed

• Package: internal/logger
• File: internal/logger/jsonl_logger.go
• Functions: LogDifcFilteredItem, LogUnrecognizedEndpointPassthrough
• Coverage Before: LogDifcFilteredItem 88.9%, LogUnrecognizedEndpointPassthrough 75.0%
• Coverage After: Both 100%

Why These Changes?

The withGlobalLogger helper (in global_helpers.go:127) already guarantees a non-nil logger before invoking any callback:

func withGlobalLogger[T closableLogger](mu *sync.RWMutex, logger *T, fn func(T)) {
    mu.RLock()
    defer mu.RUnlock()
    if *logger != nil {   // nil check happens HERE
        fn(*logger)       // fn is only called when logger is non-nil
    }
}

The if logger == nil { return } guards inside the LogDifcFilteredItem and LogUnrecognizedEndpointPassthrough callbacks were therefore unreachable dead code — the callback is only ever called with a guaranteed non-nil logger.

This is inconsistent with all other withGlobalLogger callbacks in the codebase (rpc_logger.go, observed_url_domains_logger.go) which do not have redundant nil guards.

Additional Simplification

LogUnrecognizedEndpointPassthrough also had an if/else pattern for json.Marshal where the else branch was unreachable: JSONLUnrecognizedEndpointPassthrough has only string fields, so marshaling cannot fail. Replaced with b, _ := json.Marshal(entry), matching the pattern in rpc_logger.go.

Tests

Existing tests in jsonl_logger_test.go continue to pass and cover both functions:

• TestLogDifcFilteredItem_NoLogger — verifies no panic when logger is uninitialized
• TestLogDifcFilteredItem_WritesAuditEntryToJSONL — verifies correct JSONL output
• TestLogUnrecognizedEndpointPassthrough_NoLogger — verifies no panic when logger is uninitialized
• TestLogUnrecognizedEndpointPassthrough_WritesCorrectFields — verifies correct JSONL output

Coverage Report

Before: LogDifcFilteredItem 88.9%, LogUnrecognizedEndpointPassthrough 75.0%, Total 99.5%
After:  LogDifcFilteredItem 100.0%, LogUnrecognizedEndpointPassthrough 100.0%, Total 99.7%
Improvement: +0.2%

---

Generated by Test Coverage Improver

Warning

Firewall blocked 5 domains

The following domains were blocked by the firewall during workflow execution:

• awmgmcpg
• goproxy.cn
• goproxy.io
• proxy.golang.org
• releaseassets.githubusercontent.com

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "awmgmcpg"
    - "goproxy.cn"
    - "goproxy.io"
    - "proxy.golang.org"
    - "releaseassets.githubusercontent.com"

See Network Configuration for more information.

Generated by Test Coverage Improver · 637.4 AIC · ⊞ 6.9K · ◷

[Copilot]

Pull request overview

Removes unreachable defensive branches from JSONL logging callbacks.

Changes:

• Removes redundant nil guards already enforced by withGlobalLogger.
• Simplifies marshaling of a string-only audit entry.

Show a summary per file

File	Description
internal/logger/jsonl_logger.go	Removes dead branches from two logging paths.

Review details

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

• Files reviewed: 1/1 changed files
• Comments generated: 0
• Review effort level: Medium