[Repo Assist] guard: add assign_copilot_to_issue_with_intent to WRITE_OPERATIONS and DIFC labels - #9828
Conversation
…d tool_rules Closes #9813 The assign_copilot_to_issue_with_intent tool was identified as a write operation missing from the guard's WRITE_OPERATIONS list (tools.rs) and without an explicit DIFC label rule (tool_rules.rs). Add it alongside its sibling assign_copilot_to_issue in both files. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Adds guard coverage for the new Copilot issue-assignment tool.
Changes:
- Classifies the tool as a write operation.
- Applies repository secrecy and writer-integrity labels.
Show a summary per file
| File | Description |
|---|---|
guards/github-guard/rust-guard/src/tools.rs |
Adds write classification. |
guards/github-guard/rust-guard/src/labels/tool_rules.rs |
Adds DIFC labeling. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 2/2 changed files
- Comments generated: 2
- Review effort level: Medium
| "archive_project_item", // gh project item-archive — archives a Projects v2 item | ||
| "archive_repository", // gh repo archive — blocked: repo settings change unsupported | ||
| "assign_copilot_to_issue", | ||
| "assign_copilot_to_issue_with_intent", // upstream Copilot intent assignment write |
| | "rerun_workflow_job" | ||
| // Copilot / repo settings / revert | ||
| | "assign_copilot_to_issue" | ||
| | "assign_copilot_to_issue_with_intent" |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@copilot address review feedback |
Addressed in |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@copilot resolve the merge conflicts in this pull request |
…-9813-guard-copilot-intent-f400c101f0fb6b8b # Conflicts: # guards/github-guard/rust-guard/src/tools.rs
Addressed in |
🔒 mcpg Read-Only Stress — gVisorSurface coverage: MCP tool calls + proxied CLI (REST) + GraphQL mutations
Overall: PASS Part B: gateway strips all write tools — every attempt returns MCP error References: §29966437591
|
🔒 mcpg Read-Only Stress — default AWFSurface coverage: MCP tool calls + proxied CLI (REST) + GraphQL mutations
Overall: PASS Notes:
References: §29966437606
|
🔒 mcpg Read-Only Stress — docker-sbxSurface coverage: MCP tool calls + proxied CLI (REST) + GraphQL mutations
Overall: PASS References: §29966437730
|
🤖 This is a pull request from Repo Assist, an automated AI assistant.
Closes #9813
Root Cause
The
assign_copilot_to_issue_with_intentMCP tool was identified by the guard coverage checker as a write operation present in the upstreamgithub-mcp-serverbut absent from:WRITE_OPERATIONSinguards/github-guard/rust-guard/src/tools.rsguards/github-guard/rust-guard/src/labels/tool_rules.rsFix
Added
assign_copilot_to_issue_with_intentalongside its siblingassign_copilot_to_issuein both files:assign_copilot_to_issueandcancel_workflow_runassign_copilot_to_issueandrequest_copilot_review, inheriting the same repo-visibility secrecy and writer integrity handlingTrade-offs
No trade-offs — this is a straightforward gap fill. The new tool shares the same write semantics as its sibling and belongs in the same classification bucket.
Test Status
All 596 Rust guard unit tests pass (
cargo test). Go build requires go 1.25.0 which isn't available in this sandbox (network-blocked toolchain download); the Rust changes are isolated to the guard and do not touch Go code.Warning
Firewall blocked 2 domains
The following domains were blocked by the firewall during workflow execution:
awmgmcpgproxy.golang.orgSee Network Configuration for more information.
Add this agentic workflow to your repo
To install this agentic workflow, run