Document TOML 1.1 config parsing and tighten parse-error coverage - #9846
Conversation
There was a problem hiding this comment.
Pull request overview
Documents the TOML 1.1 parsing contract and strengthens parse-error metadata coverage.
Changes:
- Documents TOML 1.1 compatibility requirements.
- Verifies parse errors contain line and column metadata.
Show a summary per file
| File | Description |
|---|---|
docs/CONFIGURATION.md |
Documents the TOML parsing contract. |
config.example.toml |
Adds compatibility guidance. |
internal/config/config_core_test.go |
Extends parse-error assertions. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 3/3 changed files
- Comments generated: 1
- Review effort level: Medium
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
🔒 mcpg Read-Only Stress — default AWFSurface coverage: MCP tool calls + proxied CLI (REST) + GraphQL mutations
Overall: PASS
References: §29965985681
|
🔒 mcpg Read-Only Stress — docker-sbxSurface coverage: MCP tool calls + proxied CLI (REST) + GraphQL mutations
Overall: PASS
References: §29965985665
|
🔒 mcpg Read-Only Stress — gVisorSurface coverage: MCP tool calls + proxied CLI (REST) + GraphQL mutations
Overall: PASS
Run: §29965985672
|
github.com/BurntSushi/tomlis already current and used appropriately in the config loader, but the user-facing config docs did not explicitly call out the TOML 1.1 parsing contract. This change makes that contract visible in the main config references and strengthens the existing parse-error test path to assert populated line/column metadata.Docs: make the TOML contract explicit
docs/CONFIGURATION.mdconfig.example.tomlTests: cover parse-error position metadata on the formatting path
FormatConfigErrortest to assert the wrappedtoml.ParseErrorincludes non-zeroPosition.LineandPosition.ColExample