Unbloat docs broken

[pelikhan]

/q Investigate why https://github.com/githubnext/gh-aw/actions/runs/19076334499 failed

[github-actions]

Agentic Q triggered by this issue.

[pelikhan]

/q the agent claims that a pull request was created but the create pull request job did not find a patch file. Investigate this run https://github.com/githubnext/gh-aw/actions/runs/19077057301/job/54495502914#step:40:1

[github-actions]

Agentic Q triggered by this issue comment.

[github-actions]

Investigation Complete: Agent Branch Name Bug

I investigated run #19077057301 and found the root cause.

Summary

The agent successfully created a branch, made changes, and committed them—but passed the wrong branch name to the create_pull_request safe-output, causing an empty patch file.

What Happened

Agent's Actions (Correct):

1. ✅ Created branch: docs/unbloat-validation-timing
2. ✅ Modified file: docs/src/content/docs/troubleshooting/validation-timing.md
3. ✅ Committed changes: SHA ea28722 (1 file changed, 22 insertions, 242 deletions)

Agent's Safe-Output Call (Incorrect):

{
  "type": "create_pull_request",
  "branch": "main",  // ❌ WRONG - should be "docs/unbloat-validation-timing"
  "title": "Unbloat validation-timing.md documentation (54% reduction)",
  "body": "..."
}

Result:

• Patch generation ran: git format-patch origin/main..main
• Found 0 commits (origin/main == local main)
• Created empty patch (0 bytes)
• PR creation job warned but didn't fail (due to if-no-changes: warn)

Evidence

From step 44 "Generate git patch":

Line 144: Extracted branch name from create_pull_request: main
Line 151: Command: git diff --stat origin/main..main
Line 153: Number of commits: 0
Line 160: Patch file size: 0 KB

The agent's commit exists locally on docs/unbloat-validation-timing but was never included in the patch because the wrong branch was specified.

Root Cause

The safe-outputs create_pull_request tool requires the branch field to specify which branch contains the changes. The agent:

• Created the correct branch name
• Committed to that branch
• But then passed "branch": "main" instead of "branch": "docs/unbloat-validation-timing"

Fix Needed

Option 1: Update workflow prompt to remind agents to use the branch they created
Option 2: Add validation to reject branch: main or default branch
Option 3: Auto-detect current branch if not specified

Investigation details saved to: /tmp/gh-aw/cache-memory/q-investigation-19077057301.md

---

🔍 AI generated by Q for #3155

AI generated by Q for #3155

[pelikhan]

@copilot apply option 1, 2, 3.