Skip to content

[task] Fix critical schema-parser mismatch: cache-memory docker-image field not implemented #3593

Description

@github-actions

Objective

Resolve the critical mismatch where cache-memory.docker-image is defined in the JSON schema but completely missing from the Go parser implementation, making this advertised feature non-functional.

Context

The schema consistency check (discussion #3589) discovered that users can configure a custom Docker image for the cache-memory MCP server in their workflow YAML, but this configuration is silently ignored because the parser doesn't implement it.

Current State:

  • Schema advertises the feature at pkg/parser/schemas/main_workflow_schema.json:2041
  • Parser struct in pkg/workflow/cache.go:19-24 omits the DockerImage field entirely
  • Users' configurations pass validation but don't work

Approach

Option A: Implement the feature (recommended if docker-image customization is needed)

  1. Add DockerImage string \yaml:"docker-image,omitempty"`to theCacheMemoryEntrystruct inpkg/workflow/cache.go`
  2. Update the extractCacheMemoryConfig function to handle the docker-image configuration
  3. Modify cache-memory MCP server generation code to use the custom image when specified
  4. Add validation to ensure the docker-image value is a valid image reference

Option B: Remove from schema (if feature is not intended)

  1. Remove the docker-image property from the cache-memory schema definition
  2. Document why this feature is not supported

Files to Modify

If implementing:

  • pkg/workflow/cache.go - Add DockerImage field to CacheMemoryEntry struct
  • pkg/workflow/cache.go - Update extractCacheMemoryConfig function
  • pkg/workflow/mcp_servers.go - Update MCP server generation to use custom image
  • pkg/workflow/cache_test.go - Add test coverage for docker-image configuration

If removing:

  • pkg/parser/schemas/main_workflow_schema.json - Remove docker-image property from cache-memory definition

Acceptance Criteria

  • Decision made: implement feature OR remove from schema
  • If implementing: DockerImage field added to struct with proper yaml tag
  • If implementing: Custom docker images are used when configured
  • If implementing: Tests verify docker-image configuration works correctly
  • If removing: Schema no longer advertises unsupported feature
  • Schema validation and parser implementation are aligned

Related Documentation

AI generated by Plan Command for discussion #3589

Metadata

Metadata

Assignees

No one assigned

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions