Overview
This is the authoritative tracking issue for the daily custom-linter function-length remediation backlog. 641 functions in pkg/workflow and related packages exceed the 60-line limit and need refactoring.
Status
- Current finding count: 641 largefunc violations
- Limit: 60 lines per function
- Primary subsystem: pkg/workflow (~640 violations)
- Secondary subsystems: pkg/cli, pkg/parser, pkg/console, pkg/stringutil, pkg/gitutil
Top Offenders (by line count)
pkg/workflow/copilot_engine_execution.go - GetExecutionSteps: 633 lines
pkg/workflow/compiler_pre_activation_job.go - buildPreActivationJob: 489 lines
pkg/workflow/claude_engine.go - GetExecutionSteps: 382 lines
pkg/workflow/compiler_main_job.go - buildMainJob: 398 lines
pkg/workflow/codex_engine.go - GetExecutionSteps: 338 lines
pkg/workflow/compiler_yaml.go - generatePrompt: 288 lines
- (... and 635 more)
Remediation Strategy
- Break down the largest functions first (>300 lines)
- Extract common patterns into helper functions
- Validate with
make golint-custom after each batch
- Track progress across multiple PR slices
Next Steps (Priority Slices)
- Slice 1: Engine execution (copilot, claude, codex GetExecutionSteps)
- Slice 2: Compiler main job and safe-outputs
- Slice 3: Remaining 150-300 line functions
- Slice 4: Smaller violations (60-150 lines)
See daily lint-monster discussion for full diagnostics and assignment details.
Generated by 🧌 LintMonster · 146.1 AIC · ⌖ 4.33 AIC · ⊞ 20K · ◷
Overview
This is the authoritative tracking issue for the daily custom-linter function-length remediation backlog. 641 functions in
pkg/workflowand related packages exceed the 60-line limit and need refactoring.Status
Top Offenders (by line count)
pkg/workflow/copilot_engine_execution.go- GetExecutionSteps: 633 linespkg/workflow/compiler_pre_activation_job.go- buildPreActivationJob: 489 linespkg/workflow/claude_engine.go- GetExecutionSteps: 382 linespkg/workflow/compiler_main_job.go- buildMainJob: 398 linespkg/workflow/codex_engine.go- GetExecutionSteps: 338 linespkg/workflow/compiler_yaml.go- generatePrompt: 288 linesRemediation Strategy
make golint-customafter each batchNext Steps (Priority Slices)
See daily lint-monster discussion for full diagnostics and assignment details.