[refactor] Reinvented semver helpers reuse pkg/semverutil

[github-actions]

🔧 Semantic Function Clustering Analysis

Analysis of repository: github/gh-aw — 2026-06-29

Executive Summary

Analyzed ~920 non-test Go files. The codebase already maintains dedicated *util packages (stringutil, sliceutil, setutil, semverutil, repoutil, jsonutil, fileutil, gitutil, ...) and is generally well-organized. The strongest actionable findings are a small cluster of semver helpers reinvented in feature files that the existing pkg/semverutil already provides, plus a few generic helpers misplaced in domain files.

The dominant noise source (wasm vs. native pairs in *_wasm.go) is intentional build-tag stubbing — not duplication. Likewise audit_math_helpers.go is already a consolidated helper file. Those are excluded.

Verified findings (high confidence)

Function	File	Duplicates	Fix
ensureSemverPrefix	pkg/cli/compile_update_check.go:323	semverutil.EnsureVPrefix (identical)	delete, call util
semverMajorMinorParts	pkg/cli/compile_update_check.go:301	semverutil.ParseVersion (.Major/.Minor)	reuse parser
isMorePreciseVersion	pkg/workflow/action_cache.go:722	semver-precision logic; near semverutil.IsPreciseVersion	move to semverutil

Side-by-side

// pkg/cli/compile_update_check.go
func ensureSemverPrefix(version string) string {
    if strings.HasPrefix(version, "v") { return version }
    return "v" + version
}
// pkg/semverutil/semverutil.go  -> EnsureVPrefix(v string) string  (same behavior)

Priority 1: Consolidate semver helpers

Move pkg/workflow/action_cache.go:isMorePreciseVersion into pkg/semverutil, and replace ensureSemverPrefix / semverMajorMinorParts in compile_update_check.go with semverutil.EnsureVPrefix / semverutil.ParseVersion. Single source of truth for version logic. Est. 1–2h.

Priority 2: Centralize stray helpers

Generic comparison/string helpers (truncateSHAForLog already wraps stringutil.Truncate ✓) and containsAny (pkg/cli/audit_agentic_analysis.go:497) overlap sliceutil. Audit per call-site; remove thin wrappers. Est. 2–3h.

Implementation checklist

• Move semver helpers into pkg/semverutil, update call sites
• Run go build ./... + tests
• Review thin slice/string wrappers for removal

Metadata

• Files analyzed: ~920 (pkg/, non-test, non-testdata) · Method: parallel symbol scan + manual verification of each finding
• Excluded: *_wasm.go build-tag stub pairs (intentional), already-consolidated helper files

Generated by 🔧 Semantic Function Refactoring · 221.4 AIC · ⌖ 14.1 AIC · ⊞ 9.2K · ◷

• expires on Jun 30, 2026, 4:14 PM UTC-08:00

[github-actions]

🍪 Issue Monster selected this for Copilot

I have identified this issue as a good candidate for automated resolution and requested assignment to the Copilot coding agent.

If assignment succeeds, the Copilot coding agent will analyze the issue and create a pull request with the fix.

Om nom nom! 🍪

🍪 Om nom nom by Issue Monster · 3.37 AIC · ⌖ 9.03 AIC · ⊞ 6K · ◷

[github-actions]

Closing this issue as a new semantic function clustering and refactoring analysis is being performed. Findings will be consolidated into a fresh report.