Skip to content

[lint-monster] Environment-coupling custom lints (2026-06-29) #42160

Description

@github-actions

Summary

Custom lint scan on 2026-06-29 found 13 environment-coupling findings. The shared root cause is library/package code reading process environment directly with os.Getenv instead of receiving configuration explicitly.

Findings

Representative diagnostics:

  • pkg/logger/logger.go — 3 findings
  • pkg/console/accessibility.go and pkg/console/spinner.go — 4 findings
  • pkg/constants/constants.go and pkg/envutil/envutil.go — 2 findings
  • pkg/github/label_objective_mapping.go — 1 finding
  • pkg/parser/github.go — 3 findings

Expected outcome

Refactor the reported call sites so libraries do not couple themselves to process environment state. Pass configuration explicitly, or isolate environment access at a boundary layer with minimal API churn.

Remediation checklist

  • Keep changes scoped to the 13 reported os.Getenv diagnostics
  • Prefer minimal, targeted edits over broad redesigns
  • Move environment reads to the outermost practical boundary and thread values inward explicitly
  • Preserve existing behavior and tests
  • Validate with make golint-custom

Copilot instructions

Use only the minimum relevant guidance: keep remediation scoped to this group, prefer small focused edits, and validate with make golint-custom. Avoid unrelated cleanup or opportunistic API redesign beyond what is required to remove the findings.

Generated by 🧌 LintMonster · 43.5 AIC · ⌖ 10.4 AIC · ⊞ 4.4K ·

  • expires on Jul 5, 2026, 7:51 PM UTC-08:00

Metadata

Metadata

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions