Description
Two near-duplicate firewall analysis structs both embed DomainBuckets + TotalRequests + allowed/blocked counts and implement AddMetrics(LogAnalysis):
pkg/cli/access_log.go:34 — DomainAnalysis
pkg/cli/firewall_log.go:133 — FirewallAnalysis (only adds RequestsByDomain)
Extract a shared analysis base and embed it in both, removing the parallel AddMetrics maintenance.
Expected Impact
One analysis base instead of two hand-synced structs; less drift risk in firewall log processing.
Suggested Agent
Code Quality agent (Go refactor).
Estimated Effort
Medium (1-2 hours)
Data Source
DeepReport Intelligence Briefing 2026-07-16, from the [typist] Go Type Consistency report (Cluster 5). Verified un-filed as of this run.
Generated by 🔬 Deep Report · 247.5 AIC · ⌖ 12.4 AIC · ⊞ 10K · ◷
Description
Two near-duplicate firewall analysis structs both embed
DomainBuckets+TotalRequests+ allowed/blocked counts and implementAddMetrics(LogAnalysis):pkg/cli/access_log.go:34—DomainAnalysispkg/cli/firewall_log.go:133—FirewallAnalysis(only addsRequestsByDomain)Extract a shared analysis base and embed it in both, removing the parallel
AddMetricsmaintenance.Expected Impact
One analysis base instead of two hand-synced structs; less drift risk in firewall log processing.
Suggested Agent
Code Quality agent (Go refactor).
Estimated Effort
Medium (1-2 hours)
Data Source
DeepReport Intelligence Briefing 2026-07-16, from the [typist] Go Type Consistency report (Cluster 5). Verified un-filed as of this run.