Skip to content

[Code Quality] Fix compiler emission bug: mount-mcp-clis step reference out of scope in generated lock files #47224

Description

@github-actions

Description

Every compiled .lock.yml workflow file emits GH_AW_MCP_CLI_SERVERS_LIST: ${{ steps.mount-mcp-clis.outputs.mcp-cli-servers-list }} in an env block where the mount-mcp-clis step is not in scope. This triggers actionlint [expression] check-syntax-expression errors on every lock file.

Current impact: 520 actionlint errors across all 260 lock files — a 5× noise spike that masks real linting signal.

Source

Extracted from Static Analysis Report 2026-07-22.

Suggested Changes

  • In the compiler template/generator, move the GH_AW_MCP_CLI_SERVERS_LIST env assignment so it appears in the same job/step scope as the mount-mcp-clis step, or reference the value through a job output accessible where needed.

Files Affected

  • pkg/workflow/template.go — YAML template that emits env assignments
  • pkg/workflow/compiler.go — compilation pipeline that sequences job steps
  • All 260 .github/workflows/*.lock.yml files will auto-fix on next make recompile

Success Criteria

  • actionlint no longer reports property "mount-mcp-clis" is not defined on any lock file
  • 520 actionlint errors eliminated; signal-to-noise restored
  • All existing tests pass
  • make recompile regenerates clean lock files

Priority

High — actionlint signal is currently dominated by this regression (5× noise increase), masking real security/lint findings.

🔍 Task mining by Discussion Task Miner - Code Quality Improvement Agent · sonnet46 91.8 AIC · ⌖ 8.11 AIC · ⊞ 7.1K ·

  • expires on Jul 22, 2026, 11:43 PM UTC-08:00

Metadata

Metadata

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions