Skip to content

[WIP] Update schema pattern for allowed GitHub references #19554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelikhan merged 2 commits into from
Mar 4, 2026
Merged

[WIP] Update schema pattern for allowed GitHub references #19554

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
72937dc
Initial plan
Copilot Mar 4, 2026
df9cb15
relax allowed-github-references schema pattern to support GitHub Acti…
Copilot Mar 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions pkg/parser/schemas/main_workflow_schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4061,10 +4061,9 @@
"type": "array",
"description": "List of allowed repositories for GitHub references (e.g., #123 or owner/repo#456). Use 'repo' to allow current repository. References to other repositories will be escaped with backticks. If not specified, all references are allowed.",
"items": {
"type": "string",
"pattern": "^(repo|[a-zA-Z0-9][-a-zA-Z0-9]{0,38}/[a-zA-Z0-9._-]+)$"
"type": "string"

Copilot AI Mar 4, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dropping the pattern here removes all schema validation for allowed-github-references. That makes it easy to silently accept typos/invalid repo specs, and it also permits arbitrary GitHub Actions expressions (e.g. ${{ secrets.MY_SECRET }}) which would be evaluated when written into GH_AW_ALLOWED_GITHUB_REFS and can be logged by the sanitizer, potentially leaking secrets. Consider keeping validation by switching items to an anyOf/oneOf that allows the supported literal formats (repo, *, owner/*, owner/repo) and only the intended macro(s) (e.g. ${{ github.repository }}), rather than allowing any string.

Suggested change
"type": "string"
"oneOf": [
{
"type": "string",
"const": "repo",
"description": "Current repository"
},
{
"type": "string",
"const": "*",
"description": "All repositories"
},
{
"type": "string",
"pattern": "^[A-Za-z0-9_.-]+/\\*$",
"description": "Owner wildcard: owner/*"
},
{
"type": "string",
"pattern": "^[A-Za-z0-9_.-]+/[A-Za-z0-9_.-]+$",
"description": "Specific repository: owner/repo"
},
{
"type": "string",
"const": "${{ github.repository }}",
"description": "Current repository via GitHub Actions context"
}
]

Copilot uses AI. Check for mistakes.
},
"examples": [["repo"], ["repo", "octocat/hello-world"], ["microsoft/vscode", "microsoft/typescript"]]
"examples": [["repo"], ["repo", "octocat/hello-world"], ["microsoft/vscode", "microsoft/typescript"], ["repo", "${{ github.repository }}"]]
},
"create-issue": {
"oneOf": [
Expand Down