Skip to content

feat: progressive disclosure for protected file messages using <details> #22300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelikhan merged 3 commits into from
Mar 22, 2026
Merged

feat: progressive disclosure for protected file messages using <details> #22300

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
167ffc8
Initial plan
Copilot Mar 22, 2026
ef44e99
feat: apply delight aesthetic and progressive discovery to protected …
Copilot Mar 22, 2026
32889ce
fix: wrap details summary text in bold b element
Copilot Mar 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion actions/setup/js/handle_agent_failure.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -369,8 +369,9 @@ function buildCodePushFailureContext(codePushFailureErrors, pullRequest = null,
yamlSnippet += ` ${yamlKey}:\n protected-files: fallback-to-issue\n`;
}
yamlSnippet += "```\n";
context += "\nTo review and apply these changes manually, configure `protected-files: fallback-to-issue` — the agent will create a review issue with instructions instead of blocking:\n";
context += "\n<details>\n<summary><b>⚙️ Configure <code>protected-files: fallback-to-issue</code></b></summary>\n\n";

Copilot AI Mar 22, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The <details> wrapper for the YAML remediation snippet removes the explanatory sentence about what protected-files: fallback-to-issue actually does (i.e., route protected-file changes to a review issue with instructions instead of blocking). Consider adding a short one-liner either in the <summary> text or immediately inside the <details> body before the code fence so readers understand the behavior change, not just the config key.

Suggested change
context += "\n<details>\n<summary><b>⚙️ Configure <code>protected-files: fallback-to-issue</code></b></summary>\n\n";
context += "\n<details>\n<summary><b>⚙️ Configure <code>protected-files: fallback-to-issue</code></b></summary>\n\n";
context += "This routes protected-file changes to a review issue with instructions instead of blocking the run.\n\n";

Copilot uses AI. Check for mistakes.
context += yamlSnippet;
context += "</details>\n";
}

// Patch size exceeded section
Expand Down
5 changes: 4 additions & 1 deletion actions/setup/md/manifest_protection_push_failed_fallback.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,8 @@
>
> The push was rejected because GitHub Actions does not have `workflows` permission to push these changes, and is never allowed to make such changes, or other authorization being used does not have this permission. A human must create the pull request manually.

To create a pull request with the changes:
<details>
<summary><b>📋 Create the pull request manually</b></summary>

```sh
# Download the patch from the workflow run
Expand All @@ -26,4 +27,6 @@ git push origin {branch_name}
gh pr create --title '{title}' --base {base_branch} --head {branch_name} --repo {repo}
```

</details>

{footer}
7 changes: 5 additions & 2 deletions actions/setup/md/manifest_protection_push_to_pr_fallback.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,13 @@

---

<details>
<summary><b>📋 Apply the patch after review</b></summary>

The patch is available in the workflow run artifacts:

**Workflow Run:** [View run details and download patch artifact]({run_url})

To apply the patch after review:

```sh
# Download the artifact from the workflow run
gh run download {run_id} -n agent -D /tmp/agent-{run_id}
Expand All @@ -26,4 +27,6 @@ git am --3way /tmp/agent-{run_id}/{patch_file_name}
git push origin {branch_name}
```

</details>

To route changes like this to a review issue instead of blocking, configure `protected-files: fallback-to-issue` in your workflow configuration.
Loading