Skip to content

Rename getPlaywrightDomainsCodemod to getPlaywrightDomainsToNetworkAllowedCodemod #22872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelikhan merged 2 commits into from
Mar 25, 2026
Merged

Rename getPlaywrightDomainsCodemod to getPlaywrightDomainsToNetworkAllowedCodemod #22872

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
72586be
Initial plan
Copilot Mar 25, 2026
58134e3
rename getPlaywrightDomainsCodemod to getPlaywrightDomainsToNetworkAl…
Copilot Mar 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pkg/cli/codemod_playwright_domains.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,9 @@ import (

var playwrightDomainsCodemodLog = logger.New("cli:codemod_playwright_domains")

// getPlaywrightDomainsCodemod creates a codemod that migrates tools.playwright.allowed_domains
// getPlaywrightDomainsToNetworkAllowedCodemod creates a codemod that migrates tools.playwright.allowed_domains
// to network.allowed. Network egress for Playwright is now controlled by the workflow firewall.
func getPlaywrightDomainsCodemod() Codemod {
func getPlaywrightDomainsToNetworkAllowedCodemod() Codemod {
return Codemod{
ID: "playwright-allowed-domains-migration",
Name: "Migrate playwright allowed_domains to network.allowed",
Expand Down
18 changes: 9 additions & 9 deletions pkg/cli/codemod_playwright_domains_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import (
)

func TestGetPlaywrightDomainsCodemod(t *testing.T) {

Copilot AI Mar 25, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test name no longer matches the constructor under test. To keep tests discoverable and consistent with the other codemod tests (e.g., codemod_roles_test.go:14), rename TestGetPlaywrightDomainsCodemod to TestGetPlaywrightDomainsToNetworkAllowedCodemod.

Suggested change
func TestGetPlaywrightDomainsCodemod(t *testing.T) {
func TestGetPlaywrightDomainsToNetworkAllowedCodemod(t *testing.T) {

Copilot uses AI. Check for mistakes.
codemod := getPlaywrightDomainsCodemod()
codemod := getPlaywrightDomainsToNetworkAllowedCodemod()

assert.Equal(t, "playwright-allowed-domains-migration", codemod.ID, "Codemod ID should match")
assert.Equal(t, "Migrate playwright allowed_domains to network.allowed", codemod.Name, "Codemod name should match")
Expand All @@ -21,7 +21,7 @@ func TestGetPlaywrightDomainsCodemod(t *testing.T) {
}

func TestPlaywrightDomainsCodemod_NoTools(t *testing.T) {
codemod := getPlaywrightDomainsCodemod()
codemod := getPlaywrightDomainsToNetworkAllowedCodemod()

content := `---
on: workflow_dispatch
Expand All @@ -43,7 +43,7 @@ permissions:
}

func TestPlaywrightDomainsCodemod_NoPlaywright(t *testing.T) {
codemod := getPlaywrightDomainsCodemod()
codemod := getPlaywrightDomainsToNetworkAllowedCodemod()

content := `---
on: workflow_dispatch
Expand All @@ -69,7 +69,7 @@ tools:
}

func TestPlaywrightDomainsCodemod_NoAllowedDomains(t *testing.T) {
codemod := getPlaywrightDomainsCodemod()
codemod := getPlaywrightDomainsToNetworkAllowedCodemod()

content := `---
on: workflow_dispatch
Expand All @@ -95,7 +95,7 @@ tools:
}

func TestPlaywrightDomainsCodemod_BasicMigration(t *testing.T) {
codemod := getPlaywrightDomainsCodemod()
codemod := getPlaywrightDomainsToNetworkAllowedCodemod()

content := `---
on: workflow_dispatch
Expand Down Expand Up @@ -129,7 +129,7 @@ tools:
}

func TestPlaywrightDomainsCodemod_PreservesVersion(t *testing.T) {
codemod := getPlaywrightDomainsCodemod()
codemod := getPlaywrightDomainsToNetworkAllowedCodemod()

content := `---
on: workflow_dispatch
Expand Down Expand Up @@ -164,7 +164,7 @@ tools:
}

func TestPlaywrightDomainsCodemod_MergesWithExistingNetwork(t *testing.T) {
codemod := getPlaywrightDomainsCodemod()
codemod := getPlaywrightDomainsToNetworkAllowedCodemod()

content := `---
on: workflow_dispatch
Expand Down Expand Up @@ -203,7 +203,7 @@ network:
}

func TestPlaywrightDomainsCodemod_DeduplicatesDomains(t *testing.T) {
codemod := getPlaywrightDomainsCodemod()
codemod := getPlaywrightDomainsToNetworkAllowedCodemod()

content := `---
on: workflow_dispatch
Expand Down Expand Up @@ -255,7 +255,7 @@ network:
}

func TestPlaywrightDomainsCodemod_SingleDomainString(t *testing.T) {
codemod := getPlaywrightDomainsCodemod()
codemod := getPlaywrightDomainsToNetworkAllowedCodemod()

content := `---
on: workflow_dispatch
Expand Down
28 changes: 14 additions & 14 deletions pkg/cli/fix_codemods.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,20 +38,20 @@ func GetAllCodemods() []Codemod {
getDiscussionFlagRemovalCodemod(),
getMCPModeToTypeCodemod(),
getInstallScriptURLCodemod(),
getBashAnonymousRemovalCodemod(), // Replace bash: with bash: false
newActivationOutputsCodemod(), // Transform needs.activation.outputs.* to steps.sanitized.outputs.*
getRolesToOnRolesCodemod(), // Move top-level roles to on.roles
getBotsToOnBotsCodemod(), // Move top-level bots to on.bots
getEngineStepsToTopLevelCodemod(), // Move engine.steps to top-level steps
getAssignToAgentDefaultAgentCodemod(), // Rename deprecated default-agent to name in assign-to-agent
getPlaywrightDomainsCodemod(), // Migrate tools.playwright.allowed_domains to network.allowed
getExpiresIntegerToStringCodemod(), // Convert expires integer (days) to string with 'd' suffix
getSerenaLocalModeCodemod(), // Replace tools.serena mode: local with mode: docker
getGitHubAppCodemod(), // Rename deprecated 'app' to 'github-app'
getSafeInputsToMCPScriptsCodemod(), // Rename safe-inputs to mcp-scripts
getPluginsToDependenciesCodemod(), // Migrate plugins to dependencies (plugins removed in favour of APM)
getGitHubReposToAllowedReposCodemod(), // Rename deprecated tools.github.repos to tools.github.allowed-repos
getDependenciesToImportsAPMPackagesCodemod(), // Migrate dependencies to imports.apm-packages (dependencies deprecated)
getBashAnonymousRemovalCodemod(), // Replace bash: with bash: false
newActivationOutputsCodemod(), // Transform needs.activation.outputs.* to steps.sanitized.outputs.*
getRolesToOnRolesCodemod(), // Move top-level roles to on.roles
getBotsToOnBotsCodemod(), // Move top-level bots to on.bots
getEngineStepsToTopLevelCodemod(), // Move engine.steps to top-level steps
getAssignToAgentDefaultAgentCodemod(), // Rename deprecated default-agent to name in assign-to-agent
getPlaywrightDomainsToNetworkAllowedCodemod(), // Migrate tools.playwright.allowed_domains to network.allowed
getExpiresIntegerToStringCodemod(), // Convert expires integer (days) to string with 'd' suffix
getSerenaLocalModeCodemod(), // Replace tools.serena mode: local with mode: docker
getGitHubAppCodemod(), // Rename deprecated 'app' to 'github-app'
getSafeInputsToMCPScriptsCodemod(), // Rename safe-inputs to mcp-scripts
getPluginsToDependenciesCodemod(), // Migrate plugins to dependencies (plugins removed in favour of APM)
getGitHubReposToAllowedReposCodemod(), // Rename deprecated tools.github.repos to tools.github.allowed-repos
getDependenciesToImportsAPMPackagesCodemod(), // Migrate dependencies to imports.apm-packages (dependencies deprecated)
}
fixCodemodsLog.Printf("Loaded codemod registry: %d codemods available", len(codemods))
return codemods
Expand Down
Loading