Skip to content

[WIP] Fix gh-aw compiler to reject env.* expressions in markdown#22930

Closed
Copilot wants to merge 1 commit into
mainfrom
copilot/reject-env-expressions-markdown
Closed

[WIP] Fix gh-aw compiler to reject env.* expressions in markdown#22930
Copilot wants to merge 1 commit into
mainfrom
copilot/reject-env-expressions-markdown

Conversation

Copilot AI commented Mar 25, 2026

Copy link
Copy Markdown
Contributor
  • Investigate the issue: env.* expressions are incorrectly allowed by validateSingleExpression via EnvRe regex
  • Remove envRegex / EnvRe from expression_safety_validation.go to block env.* expressions
  • Remove env.* from the "allowed" list shown in validation error messages
  • Update existing tests that incorrectly expect env.* to be allowed
  • Add a regression test asserting env.* expressions are rejected
  • Update benchmark tests to remove EnvRe field
  • Run make agent-finish to validate

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

@pelikhan pelikhan closed this Mar 25, 2026
Copilot AI requested a review from pelikhan March 25, 2026 17:56
Copilot stopped work on behalf of pelikhan due to an error March 25, 2026 17:56
@github-actions github-actions Bot deleted the copilot/reject-env-expressions-markdown branch April 2, 2026 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

gh-aw compiler must reject env.* expressions in markdown per documented safety policy

2 participants