Skip to content

Harden GH_AW_MCP_CLI_SERVERS shell export to resolve code scanning alert #580 #31238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelikhan merged 2 commits into from
May 9, 2026
Merged

Harden GH_AW_MCP_CLI_SERVERS shell export to resolve code scanning alert #580 #31238

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e52cab3
Initial plan
Copilot May 9, 2026
dcdb26a
Fix shell escaping for GH_AW_MCP_CLI_SERVERS export
Copilot May 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions pkg/workflow/mcp_setup_generator.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -607,8 +607,9 @@ func writeMCPGatewayExports(yaml *strings.Builder, tools map[string]any, engine
if cliServers := getMCPCLIExcludeFromAgentConfig(workflowData); len(cliServers) > 0 {
cliServersJSON, err := json.Marshal(cliServers)
if err == nil {
yaml.WriteString(" export GH_AW_MCP_CLI_SERVERS='" + string(cliServersJSON) + "'\n")
yaml.WriteString(" echo 'GH_AW_MCP_CLI_SERVERS=" + string(cliServersJSON) + "' >> \"$GITHUB_ENV\"\n")
escapedCLIServersJSON := shellEscapeArg(string(cliServersJSON))
yaml.WriteString(" export GH_AW_MCP_CLI_SERVERS=" + escapedCLIServersJSON + "\n")
yaml.WriteString(" echo GH_AW_MCP_CLI_SERVERS=" + escapedCLIServersJSON + " >> \"$GITHUB_ENV\"\n")
}
}
if hasGitHub && getGitHubType(githubTool) == "remote" && engine.GetID() == "copilot" {
Expand Down