Emit unquoted top-level on: in compiled .lock.yml workflows

[Copilot]

Bug Fix

gh aw compile currently emits top-level workflow triggers as "on":, which is valid YAML but inconsistent with GitHub Actions conventions and tooling expectations. This change normalizes compiled lock files to use unquoted top-level on: while leaving nested quoted keys untouched.

• What was the bug?

  Generated *.lock.yml used "on": at the root, creating avoidable inconsistency with hand-authored workflows and editor/linter heuristics keyed on on:.

• How was it fixed?

  • Added a targeted post-processing helper to unquote only the top-level key when it is exactly "on":.
  • Applied that normalization in workflow body generation after existing on-section transformations.
  • Preserved nested behavior intentionally (no broad unquoting pass).

• Scope of updates

  • Updated affected assertions in event/centralized command compile tests that previously expected "on":.
  • Added focused unit coverage for top-level-only unquoting semantics.
  • Updated wasm golden fixtures to reflect the normalized on: output.

# before
name: "PR Documentation Check"
"on":
  pull_request:
    branches:
    - main

# after
name: "PR Documentation Check"
on:
  pull_request:
    branches:
    - main

[Copilot]

Pull request overview

Normalizes the compiled *.lock.yml workflow output to emit an unquoted top-level on: key (instead of "on":) for consistency with hand-authored GitHub Actions workflows, while intentionally leaving nested quoted keys unchanged.

Changes:

• Adds UnquoteYAMLTopLevelKey helper in pkg/workflow/yaml.go and invokes it in generateWorkflowBody after existing on-section transformations.
• Adds focused unit tests for the helper and a regex-based assertion in compiler_validation_test.go to guard the top-level on: form.
• Updates affected event/centralized command compile test expectations and wasm golden fixtures to the new unquoted output.

Show a summary per file

File	Description
pkg/workflow/yaml.go	New top-level-only unquoting helper with doc comment.
pkg/workflow/yaml_test.go	Unit tests for UnquoteYAMLTopLevelKey covering top-level, nested, and already-unquoted cases.
pkg/workflow/compiler_yaml.go	Applies the new helper to the on section in workflow body generation.
pkg/workflow/compiler_validation_test.go	Regex assertion ensuring generated YAML has unquoted top-level on:.
pkg/workflow/compiler_events_test.go	Updates expected on strings to the unquoted form.
pkg/workflow/slash_command_centralized_compile_test.go	Updates expected substring to the unquoted form.
pkg/workflow/testdata/TestWasmGolden_CompileFixtures/*.golden	Golden updates to reflect unquoted on:.
pkg/workflow/testdata/wasm_golden/WasmBinary/*.golden	Wasm golden updates to reflect unquoted on:.
.github/workflows/ci-coach.lock.yml	Large lock file regeneration; still contains "on": and includes unrelated version/structure drift.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

• Files reviewed: 15/15 changed files
• Comments generated: 1