Skip to content

Strengthen timeout_minutes codemod tests with multiple-occurrence coverage #33385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelikhan merged 3 commits into from
May 19, 2026
Merged

Strengthen timeout_minutes codemod tests with multiple-occurrence coverage #33385

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7279377
Initial plan
Copilot May 19, 2026
385fd9c
test: add multiple-occurrence timeout_minutes codemod coverage
Copilot May 19, 2026
7ae0ea9
test: align frontmatter fixture in timeout multiple-occurrence test
Copilot May 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 31 additions & 0 deletions pkg/cli/codemod_timeout_minutes_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,3 +236,34 @@ custom_timeout_minutes: 60
assert.True(t, foundTimeoutMinutes, "Should replace timeout_minutes")
assert.True(t, foundCustomTimeoutMinutes, "Should not replace custom_timeout_minutes")
}

func TestTimeoutMinutesCodemod_MultipleOccurrences(t *testing.T) {
codemod := getTimeoutMinutesCodemod()

content := `---
on: workflow_dispatch
timeout_minutes: 30
jobs:
setup:
timeout_minutes: 45
---

# Test`

frontmatter := map[string]any{
"on": "workflow_dispatch",
"timeout_minutes": 30,
"jobs": map[string]any{
"setup": map[string]any{
"timeout_minutes": 45,
},
},
}

result, applied, err := codemod.Apply(content, frontmatter)

require.NoError(t, err, "Apply should not return an error")
assert.True(t, applied, "Codemod should report changes")
assert.Equal(t, 2, strings.Count(result, "timeout-minutes:"), "Codemod should replace all timeout_minutes occurrences in frontmatter")
assert.NotContains(t, result, "timeout_minutes:", "Result should not contain old field name")
}