Harden run step env map allocation against integer overflow in sanitizer#33552
Closed
Copilot wants to merge 3 commits into
Closed
Harden run step env map allocation against integer overflow in sanitizer#33552Copilot wants to merge 3 commits into
Copilot wants to merge 3 commits into
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix code scanning alert #597
Harden run step env map allocation against integer overflow in sanitizer
May 20, 2026
Contributor
|
Hey
Since this is a bot-generated PR for the core team workflow, the typical contribution process doesn't fully apply, but completing the validation steps will help ensure the changes are safe. Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
network:
allowed:
- defaults
- "patchdiff.githubusercontent.com"See Network Configuration for more information.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses a CodeQL code-scanning finding in the run-step sanitizer where map capacity was computed with overflow-prone integer addition. The change removes the risky allocation-size arithmetic while preserving sanitizer behavior.
What changed
sanitizeRunStepExpressionsinpkg/workflow/run_step_sanitizer.goto avoidlen(existingEnv)+len(ordered)inmake(...)capacity.len(existingEnv)and relies on normal map growth for injected entries.Why this resolves the alert